Bug report #9604
Attribute table: the icons for "Unselect all" and "Delete selected features" are too similar
|Affected QGIS version:||master||Regression?:||No|
|Operating System:||Easy fix?:||No|
|Pull Request or Patch supplied:||No||Resolution:|
|Crashes QGIS or corrupts data:||No||Copied to github as #:||18182|
Every time I open the attributes table I end up mixing these two buttons, because the icons are tool similar. It would be nice to change one of them.
#4 Updated by Anita Graser almost 7 years ago
- File edit_toolbar.png added
The delete selected icon is also used in the editing toolbar. In my opinion, the delete selected icon is inconsistent here. I think it should display the same green polygon as featured in the other toolbar icons instead of the yellow rectangle.
#5 Updated by Robert Szczepanek almost 7 years ago
We probably should simplify and more rely on the context. For delete (any object, selection) I would use just red X.
Unselect is more difficult. This operation applies always to selected, so we can skip 'yellow selection' and just put the action part. First I wanted to make it gray, but then we end up with usability issue - is this icon active? Yellow is related to selection, so it should work.
And in edit toolbar we put just 'delete' (meaning - delete selected). It will not depended on vector type (polygon/line/point).
Please don't look at the quality of images.
#7 Updated by Alexandre Neto almost 7 years ago
I would propose changes to both icons as well to improve the differences but try keep the logic to other icons.
For unselection, using a dotted rectangle around selection would emphasize the fact that we are talking about selections.
Using a yellow polygon, would reflect the fact that only selected features are deleted, and will differenciate from delete part.
#10 Updated by Anita Graser almost 7 years ago
Thanks for your input @Tobias! Since you are raising a new issue in your second post, it would be good to open a new ticket. Otherwise this thread will probably get too confusing if we start to discuss multiple issues at once. So please open a new ticket to discuss grouping.
#11 Updated by Anita Graser over 6 years ago
- Target version set to Future Release - High Priority
- File delete_and_unselect2.png added
Using Alexandre Neto's suggestion for delete selected adds both consistency in the editing toolbar and a visible difference in the attribute table GUI:
Robert, would that be ok for you? Could you create the icon?
#14 Updated by Alexandre Neto over 6 years ago
In fact, using the green color is more in line with what's used in the digitizing toolbars (new feature, move feature, rotate feature and delete part). Don't know if those icons are not too similar to distinguish with a quick glance. The difference will lay almost only on the small icon in the right corner. And that might become a new problem.
#15 Updated by Robert Szczepanek over 6 years ago
Proposal is here:
Main issue with those two icons was that they are too similar. So the less similar - the better. As deselect is used not only here, it should be somehow universal and simple (like for 16x16px icons in tables).
Delete selected is modified according Alexandre Neto suggestion.
#17 Updated by Jan Lippmann over 6 years ago
- File some_selections_buttons_arcgis10.png added
another idea would be, if one is oriented to arcgis. i've added a screenshot with some selectiontools.
i think its important to think about the color. in arcgis the default selectioncolor is: 0 255 255 (RGB). this color is very good for selections because the color is not used often for symbolization and the selection of very small features are very good visible in the map, compared to other colors. so this selection color could also be the color for every selectiontoolbuttons in qgis. additional the look and feel, if i switch between qgis and arcgis, is better.
what do you think?
#20 Updated by Nyall Dawson over 6 years ago
I agree with Nathan about the unselect icon. I also think the "delete" symbol in the delete icon should be much more prominent - at the moment it still looks more like a selection tool than a delete tool. Making the red delete box larger and using a polygon shape in the background (like Anita's mockup in #11) would probably fix this.
#23 Updated by Nathan Woodrow over 6 years ago
Jan Lippmann wrote:
what do you think about the color (RGB:0 255 255) for selectionbuttons?
influences are not desirable from arcgis?
I prefer the yellow as we have now. That is already an established colour so no need to change that aspect. The select area when using the tool in the master now also matches the colour of the buttons too.
#24 Updated by Anita Graser over 6 years ago
@Jan: The idea of the Arcgis icons is not bad but it would require changes to all the other select icons we are currently using. I'd like to keep work load low.
@Tobias: Do you know of a recycling bin icon which would work in the tiny space that we have available? I think "x" is quite well established for deletion.
@Nyall: +1 for having a polygon in the background of the Delete selected tool. <== @Robert would that be ok for you?
#25 Updated by Tobias Schneider over 6 years ago
@Anita: With the current icons, the small inlet is really too small to fit a recycle-bin. I tried around a little bit but the readability is impossible.
Of course, if the interface looses a few icons, we could also make 30x30px (for a standard pixel density screen) icons which would be a boost to readability.
#29 Updated by Anita Graser about 6 years ago
I see. So only a bin, no composite symbol ... Could work both in the attribute table and in the editing toolbar.
Do we already have a red bin icon anywhere which we could reuse here or do we need to make one?
Maybe similar to https://www.iconfinder.com/icons/175162/full_trash_icon#size=32
#35 Updated by Nathan Woodrow about 6 years ago
I have gone with a slightly different icon to the ones I posted although it's pretty much the same. The remove icon was really too much red and was a bit harsh around all the others on the row.
This is what is there now:
I think this one scales nicely and stands out better on the edit toolbar and the attribute table.