Bug report #17030

QGIS 2.99.0-149 modeler, algorithm input does not restrict to valid shape types

Added by Jochen Schwarze almost 3 years ago. Updated over 2 years ago.

Status:Closed
Priority:High
Assignee:Victor Olaya
Category:Processing/Modeller
Affected QGIS version:master Regression?:Yes
Operating System:Windows 10 Easy fix?:No
Pull Request or Patch supplied:No Resolution:fixed/implemented
Crashes QGIS or corrupts data:No Copied to github as #:24929

Description

In QGIS 2.99.0 modeler there is a new input type called 'Feature Source', what does, what 'Vector Layer' did in previous versions ([[https://gis.stackexchange.com/questions/252373/qgis-2-99-0-149-modeler-inputs-feature-source-vs-vector-layer]]).

In previous versions QGIS modeler algorithm inputs did restrict the list of selectable input layers to valid shape types (e.g. a polygon input and a point input in 'Count points in polygon' algorithm). QGIS 2.99.0 lacks this behaviour at this point, so it would be possible to pass a point input layer to an algorithm where a polygon layer is expected (and vice versa, cp. attached screeshot).

299_alg_input.jpg - Select polygon where point is expected (234 KB) Jochen Schwarze, 2017-08-17 01:29 PM

Associated revisions

Revision 7d69e5f5
Added by Nyall Dawson almost 3 years ago

Expose all layer type filters to both model feature source, vector
layer and multi layer inputs

Refs #17030

Revision cb70aad7
Added by Nyall Dawson almost 3 years ago

Fix restricting model algorithm input types to valid types for alg (refs #17030)

History

#1 Updated by Giovanni Manghi almost 3 years ago

  • Priority changed from Normal to High

#2 Updated by Etienne Trimaille almost 3 years ago

I agree, it's very confusing this new terminology. It would be nice to have some documentations.

#3 Updated by Jochen Schwarze almost 3 years ago

So with exposing all layer type filters vector layer input (2.99.0-151), we can use either feature source or vector layer as algorithm input. Obviously they are treated the same, which can be confusing (cp. gis.se question referred to above), Why this distinction?

#4 Updated by Jochen Schwarze over 2 years ago

  • Status changed from Open to Closed

Set to closed, tested with 2.99.0-166

#5 Updated by Giovanni Manghi over 2 years ago

  • Resolution set to fixed/implemented

Also available in: Atom PDF