QGIS » QGIS Application

the following patch resolves the issue. Tested and matches item names as well as tags.

Can Arun please review it? I wonder why the query was on the xml field instead of the name field.

diff --git a/src/core/symbology-ng/qgsstylev2.cpp b/src/core/symbology-ng/qgsstylev2.cpp
index 459230b..3648229 100644
--- a/src/core/symbology-ng/qgsstylev2.cpp
+++ b/src/core/symbology-ng/qgsstylev2.cpp
@@ -753,7 +753,7 @@ QStringList QgsStyleV2::findSymbols( StyleEntity type, QString qword )
   }

   QString item = ( type == SymbolEntity ) ? "symbol" : "colorramp";
-  char *query = sqlite3_mprintf( "SELECT name FROM %q WHERE xml LIKE '%%%q%%'",
+  char *query = sqlite3_mprintf( "SELECT name FROM %q WHERE name LIKE '%%%q%%'",
                                   item.toUtf8().constData(), qword.toUtf8().constData() );

   sqlite3_stmt *ppStmt;

Attaching a patch with debug statements

Etienne Tourigny wrote:

the following patch resolves the issue. Tested and matches item names as well as tags.

Hi,
better submit the patch on github, otherwise there is the real chance of not being evaluated and committed.

I understand now why it works this way, but I don't see the real usefulness. It is rather un-intuitive, I was honestly expecting a name-based search.

Also, a basic xml search will return values based on the tags and not their content (although I didn't test that).

Perhaps in 2.1 you could have 2 search options, one traditional (on the name) and another on the xml, or something more complex, like a selector for name/color/etc?

cheers

Fixed in changeset 09675101452bdd1cde8dfdf4c7482164eca0be3b.