Bug report #7743
Vector layer join broken if not using cached join
| Status: | Closed | ||
|---|---|---|---|
| Priority: | High | ||
| Assignee: |  Chris Crook | ||
| Category: | Vectors | ||
| Affected QGIS version: | master | Regression?: | No |
| Operating System: | Easy fix?: | No | |
| Pull Request or Patch supplied: | Yes | Resolution: | |
| Crashes QGIS or corrupts data: | No | Copied to github as #: | 16648 |
Description
I noticed a couple of errors in the implementation of the Vector layer join which means it may display incorrect data when not using a memory cache.
1) If the joined layer already has a subset string, then the layer is joined by added ' AND name=value' to the original. To be safe the original subset string should be parenthesised
2) The implementation of 'AND name=value' is wrong - the value is enclosed in double quotes rather than apostrophes.
Associated revisions
History
#1
Updated by Chris Crook over 11 years ago
- Assignee set to Chris Crook
#2
Updated by Chris Crook over 11 years ago
- Pull Request or Patch supplied changed from No to Yes
#3
Updated by Giovanni Manghi over 11 years ago
- Status changed from Open to Feedback
Hi, can someone commit the patch so we can test? cheers!
#4
Updated by Chris Crook over 11 years ago
Hi Giovanni
I couldn't commit this when I submitted it (though I could now). But probably should be left to someone else, as not really in my area (delimited text provider).
#5
Updated by Paolo Cavallini over 11 years ago
Better check and apply if ok
#6
Updated by Giovanni Manghi over 11 years ago
Paolo Cavallini wrote:
Better check and apply if ok
right now there a a lot of patches on github needing to be reviewed and eventually applied. Most of them fixing bugs. Better to insist in the dev mailing list.
#7
Updated by Jürgen Fischer over 11 years ago
- Status changed from Feedback to Closed
Fixed in changeset c04a130a990d60a70696da76f6eedac135b72f12.