Bug report #5616

"Add" button is enabled when no PostGIS layers are selected

Added by Mike Toews over 5 years ago. Updated over 1 year ago.

Status:Closed
Priority:Low
Assignee:-
Category:GUI
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No

Description

In the "Add PostGIS Table(s)" dialog, when no layers are selected, the "Add" button is enabled. Clicking this button shows an information dialog:

You must select a table in order to add a layer.

Although this is all logical at a basic level, it could be confusing to the user. Particularly if they had already selected a layer, then double-clicked it to build a query, and the layer became unselected. The "Add" button should only be enabled when there are greater than zero layers selected, otherwise it should be disabled.

As a minor touch-up, the dialog does not list PostGIS "tables", rather they are layers (as the pop-up text shows for the icon). These can be any number of combinations of tables and/or views with one or more geometry/geography columns .. or simply put, layers.

Associated revisions

Revision 7132209f
Added by Alexander Bruy over 1 year ago

enable Add button in DB dialogs only when at least one table is selected (fix #5616)

Revision 427559c8
Added by Alexander Bruy over 1 year ago

Merge pull request #3100 from alexbruy/add-db-table

enable Add button in DB dialogs only when at least one table is selected (fix #5616)

History

#1 Updated by Paolo Cavallini about 5 years ago

  • Target version set to Version 2.0.0

#2 Updated by Giovanni Manghi about 3 years ago

  • Target version changed from Version 2.0.0 to Future Release - Lower Priority

#3 Updated by Médéric RIBREUX almost 2 years ago

Hello, bug triage...

still true in QGIS 2.13...

#4 Updated by Alexander Bruy over 1 year ago

  • Status changed from Open to Closed

Also available in: Atom PDF