Bug report #2465

Georeferencer: does not correctly handle files with existing georeferencing information

Added by mmassing - almost 10 years ago. Updated about 7 years ago.

Status:Closed
Priority:Normal
Assignee:mmassing -
Category:C++ Plugins
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:12525

Description

When opening an already georeferenced raster, any added GCPs
are expressed in geocoordinates instead of pixel coordinates,
and the derived coordinate transform used for the warp is therefore
incorrect in general.

qgsrasterlayer_ignore_geotransform.diff Magnifier (6.3 KB) mmassing -, 2010-06-12 02:38 AM

georeferencer_26jun2011.zip (233 KB) Luiz Motta, 2011-06-26 11:32 AM

georeferencer_27jun2011.zip_ (238 KB) Luiz Motta, 2011-06-26 09:15 PM

Georeference_path.png (861 KB) Luiz Motta, 2011-06-28 05:01 AM

History

#1 Updated by mmassing - over 9 years ago

We discussed a possible workaround in http://lists.osgeo.org/pipermail/qgis-developer/2010-May/009825.html, but as the solution does not seem very clean I hope to address the problem as part of some other pending changes to the georeferencer.

Moving back to 1.6 for now.

#2 Updated by Luiz Motta over 8 years ago

I made some changes in georeferencer plugin to work with georeferenced image.
Too, i changed the coordinates showed in GCP table, now, the coordinate is the same showed in window of georeference plugin.
The next steps are the corrections:
1) The lenght of line residual (red color) in window of georeference plugin for the case use georeferenced image.
2) Correct the script for GDAL
3) Add the raster toolbar with histogram stretch functions inside georeference windows.

In attached (georeferencer_26jun2011.zip) the sources of Georeference with the list of exit of diff command.
Usage of diff:
diff /home/lmotta/dev/cpp/qgis-Quantum-GIS-b9f4c15/src/plugins/georeferencer /home/lmotta/dev/cpp/qgis_plugin/georeferencer > diff_georeference_26june2011.txt

#3 Updated by Luiz Motta over 8 years ago

Concluded the step 3 (Add the raster toolbar with histogram stretch functions) and added the EPSG code for image with georeference in status bar.

In attached (georeferencer_27jun2011.zip) the sources of Georeference with the list of exit of diff command.
Usage of diff:
diff /home/lmotta/dev/cpp/qgis-Quantum-GIS-b9f4c15/src/plugins/georeferencer /home/lmotta/dev/cpp/qgis_plugin/georeferencer > diff_georeference_27june2011.txt

#4 Updated by Luiz Motta over 8 years ago

Capture screen of Georeference Plugin with the path(georeferencer_27jun2011.zip) running:

#5 Updated by Giovanni Manghi almost 8 years ago

  • Target version changed from Version 1.7.0 to Version 1.7.4

#6 Updated by Giovanni Manghi almost 8 years ago

  • Affected QGIS version set to master
  • Crashes QGIS or corrupts data set to No
  • Pull Request or Patch supplied set to Yes

Can someone review and apply the patch?

#7 Updated by Andrea Pacifici over 7 years ago

I ran into this problem several times. This bug is a big problem for my work (planetary geology) and forces me to use other softwares to get around the problem. I hope this patch will be applied ASAP.

Giovanni Manghi wrote:

Can someone review and apply the patch?

#8 Updated by Giovanni Manghi over 7 years ago

  • Operating System deleted (All)
  • Status info deleted (0)

Luiz Motta wrote:

Concluded the step 3 (Add the raster toolbar with histogram stretch functions) and added the EPSG code for image with georeference in status bar.

In attached (georeferencer_27jun2011.zip) the sources of Georeference with the list of exit of diff command.
Usage of diff:
diff /home/lmotta/dev/cpp/qgis-Quantum-GIS-b9f4c15/src/plugins/georeferencer /home/lmotta/dev/cpp/qgis_plugin/georeferencer > diff_georeference_27june2011.txt

dear Luiz, I would like to test your patch but I cannot make to apply it. It was made using diff? Thanks in advance.

#9 Updated by Giovanni Manghi over 7 years ago

  • Status changed from Open to Feedback

Luiz Motta wrote:

Concluded the step 3 (Add the raster toolbar with histogram stretch functions) and added the EPSG code for image with georeference in status bar.

In attached (georeferencer_27jun2011.zip) the sources of Georeference with the list of exit of diff command.
Usage of diff:
diff /home/lmotta/dev/cpp/qgis-Quantum-GIS-b9f4c15/src/plugins/georeferencer /home/lmotta/dev/cpp/qgis_plugin/georeferencer > diff_georeference_27june2011.txt

When I try to apply the patch I get

patch: ** Only garbage was found in the patch input.

Can you help?

#10 Updated by Paolo Cavallini over 7 years ago

  • Target version changed from Version 1.7.4 to Version 1.8.0

#11 Updated by Paolo Cavallini over 7 years ago

  • Target version changed from Version 1.8.0 to Version 2.0.0

#12 Updated by Magnus Homann about 7 years ago

  • Status changed from Feedback to Closed

Patch included in

847cae91118b6046ece0e06ea3103fe59467832f

and seeems to work! Thanks!

Also available in: Atom PDF