Bug report #19724

Algorithm shortcuts in Vector & Raster menus shouldn't be capitalized in most languages

Added by Borys Jurgiel almost 2 years ago. Updated over 1 year ago.

Status:Closed
Priority:Normal
Assignee:Nyall Dawson
Category:Processing/GUI
Affected QGIS version:3.3(master) Regression?:Yes
Operating System: Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:27549

Description

These Processing shortcuts are now capitalised after being translated.

In most languages menus (and generally titles) are not supposed to be capitalised. I can speak for Slavic languages where it looks really oddly, but I believe it's quite the same in most European languages, including German, French, Spain, Italian etc. Looking through our i18n, I've only found capitalized menus in Portuguese Portuguese (unlike Brasilian Portuguese) and somehow partially in Romanian.

So I'd perform the capitalization only if the system locale is on a white list (or rather the GUI language, as it can be overwritten by user).

I'm not sure if it should be a local change in python/plugins/processing/gui/menus.py, or just the QgsStringUtils::capitalize() should always fallback TitleCase to MixedCase if the current language is not "capitalistic" ;)

Screenshot_20180828_114117.png (56.5 KB) Borys Jurgiel, 2018-08-28 11:41 AM

Associated revisions

Revision d0813a88
Added by Borys Jurgiel over 1 year ago

Introduce QgsGui::HigFlags and don't capitalize menu entries and dialog titles in languages other than English. Fixes #19724

History

#2 Updated by Harrissou Santanna almost 2 years ago

  • Subject changed from Algorithm shortcuts in Vector & Raster menus shouldn't by capitalized in most languages to Algorithm shortcuts in Vector & Raster menus shouldn't be capitalized in most languages

Thanks for raising this, Borys.
I guess your issue also concerns Processing dialog titles being capitalized when run from these shortcuts or the toolbox (but not from the modeller btw).

#3 Updated by Harrissou Santanna over 1 year ago

  • Affected QGIS version changed from 3.2 to 3.3(master)

Hi, May I ask if there's any progress on this?
If using title case for dialogs seems to make dialogs look pretty in English, in French (in my case), it's really ugly and against HIG. Same for menu items.
Would be nice if this can be fixed before the release (I get complaints from users that do not understand why the GUI does not reflect their translations).
Thanks.

#4 Updated by Borys Jurgiel over 1 year ago

  • Description updated (diff)

#5 Updated by Borys Jurgiel over 1 year ago

I'm just fixing it.

#6 Updated by Borys Jurgiel over 1 year ago

  • Pull Request or Patch supplied changed from No to Yes

#8 Updated by Harrissou Santanna over 1 year ago

Thank you very much, Borys.

#9 Updated by Borys Jurgiel over 1 year ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

Also available in: Atom PDF