Bug report #17367

Offset tool doesn't honor snapping configuration

Added by Loïc BARTOLETTI about 3 years ago. Updated almost 3 years ago.

Status:Closed
Priority:Normal
Assignee:Denis Rouzaud
Category:Digitising
Affected QGIS version:2.18.13 Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:fixed/implemented
Crashes QGIS or corrupts data:No Copied to github as #:25264

Description

This tool (maybe others?) have a hardcoded configuration:

//snap cursor to background layers
QgsPointLocator::Match m = mCanvas->snappingUtils()->snapToMap( e->pos() );
if ( m.isValid() ) {
if ( ( m.layer() && m.layer()->id() != mSourceLayerId ) || m.featureId() != mModifiedFeature ) {
layerCoords = toLayerCoordinates( layer, m.point() );
mSnapVertexMarker = new QgsVertexMarker( mCanvas );
mSnapVertexMarker->setIconType( QgsVertexMarker::ICON_CROSS );
mSnapVertexMarker->setColor( Qt::green );
mSnapVertexMarker->setPenWidth( 1 );
mSnapVertexMarker->setCenter( m.point() );
}
}

Associated revisions

Revision e1d481fa
Added by Denis Rouzaud almost 3 years ago

various fixes to the offset map tool

code has been refactored, hopefully things are clearer now
fix #17367
fix #14751

History

#1 Updated by Denis Rouzaud almost 3 years ago

  • Assignee set to Mathieu Pellerin - nIRV

Matthieu, are you about to take care of this tool?
Let me know

#2 Updated by Denis Rouzaud almost 3 years ago

see #15201

#3 Updated by Mathieu Pellerin - nIRV almost 3 years ago

Denis, not on my agenda for the foreseeable future, feel free to take ownership here :)

#4 Updated by Denis Rouzaud almost 3 years ago

  • Assignee changed from Mathieu Pellerin - nIRV to Denis Rouzaud

#5 Updated by Denis Rouzaud almost 3 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

#6 Updated by Giovanni Manghi almost 3 years ago

  • Resolution set to fixed/implemented

Also available in: Atom PDF