Bug report #15822
Singleparts to multi-part polygon algorithm uses NULL values also
Status: | Closed | ||
---|---|---|---|
Priority: | Normal | ||
Assignee: | - | ||
Category: | Processing/QGIS | ||
Affected QGIS version: | 2.14.2 | Regression?: | No |
Operating System: | Easy fix?: | No | |
Pull Request or Patch supplied: | No | Resolution: | fixed/implemented |
Crashes QGIS or corrupts data: | No | Copied to github as #: | 23742 |
Description
I have a polygon shapefile with an attribute villageID, in which some polygons have the same attribute value and so they should together form a single multi-part polygon. Some other polygons have NULL in this villageID field. When I run the tool Vector>Geometry Tools>Singleparts to Multipart (from the menu or from Procsesing Toolbox, and whether I use the GDAL version or the QGIS geoalgorithm version), the resulting shapefile does merge the repeated villageIDs into multi-part polygons. But it ALSO merges ALL the polygons that had this field = NULL into a SINGLE multi-part polygon. In effect, it is treating all NULL values as equal, when in fact it should treat NULL as 'not known' and ignore those polygons. If I run a 'find duplicates' query in MS-ACCESS on the attribute table dbf, the query ignores those rows where villageID=NULL, which IMHO is the correct method.
Associated revisions
[processing] handle NULL values in the Singleparts to multiparts (fix #15822)
Revert "[processing] handle NULL values in the Singleparts to multiparts (fix #15822)"
This reverts commit a944f7c4c1010767abb811200686e327040c2d32.
[processing] handle NULL values in the single to multi algorithm (fix #15822)
[processing] handle NULL values in the single to multi algorithm (fix #15822)
[processing] handle NULL values in the single to multi algorithm (fix #15822)
History
#1 Updated by Alexander Bruy over 7 years ago
- Category set to Processing/QGIS
#2 Updated by Alexander Bruy over 7 years ago
- Status changed from Open to Closed
- Resolution set to fixed/implemented
Fixed in a944f7c4c1
#3 Updated by Jürgen Fischer over 7 years ago
- Status changed from Closed to Reopened
- Regression? set to No
- Resolution deleted (
fixed/implemented) - Easy fix? set to No
#4 Updated by Alexander Bruy over 7 years ago
- Status changed from Reopened to Closed
- % Done changed from 0 to 100
Applied in changeset qgis|e4d745fee3df0026d3629b32ef3aaa06ca7a9d4f.
#5 Updated by Giovanni Manghi over 7 years ago
- Resolution set to fixed/implemented