QGIS » QGIS Application

Sorry for being so lame, but could you please explain step "1. Open a vector layer stored in a file geodatabase (I'm using the ESRI FileGDB driver)" ? How do I do that ?

Figured, I could open it (http://gis.stackexchange.com/questions/26285/file-geodatabase-gdb-support-in-qgis) -- but I only have the OpenFileGDB driver.

So even with OpenFileGDB driver I confirm the issue, but the issue for me happens with both input datasets. This is with current master_2 branch (2.17)

Actually, I cannot confirm 2.14 is fine.
Following the code it seems that he "layername" is extracted from the input layer uri, which for a geodatabase can look like this:

/home/strk/lab/qgis/bugs/b15698/vector2.gdb|layerid=1 (I get this for vector2 testpoint)
/home/strk/lab/qgis/bugs/b15698/vector2.gdb (I get this for vector2 testpolygon)
/home/strk/lab/qgis/bugs/b15698/vector.gdb (I get this for vector testpolygon MultiPolygon)

Either the URI is wrong or just not enough to be used to reference the content.
In none of the above cases the ogr2ogr call gets either "vector2" or "vector" for the dataset name (also with 2.14.7 here)

Thanks for having a look at this problem... Here's what I get (using Windows, btw.):

2.14.7: layer source complete if I use the data in the "vector2" geodatabase
2.14.7: layer source incomplete if I use the data in the "vector" geodatabase

2.16.3: layer source incomplete for both geodatabases

Apparently the OGR data provider in 2.14.7 behaves differently if there's more than one dataset in a file geodatabase.

Sandro Santilli wrote:

This boils down to the "Layer source" being incomplete for the loaded layers
(double click on the loaded layers to verify, check General.Layer_source, it's missing the dataset name)

does the datasource only have one layer? then the layer name/id is optional.

vector2 has 2 layers, loading both results in one having 'layerid=1' and the other not having any 'layerid' in the DatasourceUri (I guess it would default to layerid=0).

Jérôme Guélat wrote:

Thanks for having a look at this problem... Here's what I get (using Windows, btw.):

2.14.7: layer source complete if I use the data in the "vector2" geodatabase

For both layers in that file ?
Which GDAL/OGR version ?
Also, can you show the complete layer source ?
And, is the ogr2ogr commandline correct when you import the layer with the complete "layer source" ?

Apparently the OGR data provider in 2.14.7 behaves differently if there's more than one dataset in a file geodatabase.

Do you know the exact commit you're using of 2.14.7 ?

Ok now I see the 2.14 thing.
I was confused by the fact that I was opening a project saved with 2.16.
When you open a geodatabase with 2.14, the "Layer source" (DatasourceURI) does indeed contain a "|layername=xxx" suffix for the multi-layer input, and no suffix for the single-layer input.

In 2.16 and later, instead, you get "|layerid=1" for datasets other_than_the_first_one in any geodatabase.

Having "layername" in the URI is great as you can get to the dataset name from the URI itself. I'm not sure why the Ogr provider changed that as the new convention seems less useful.

In any case, fixing the provider isn't enough as it would still leave us with datasets that may still have the URI encoded in the bogus way. Unless we make the provider re-write the URI right after reading (recommended).

*Results for 2.14.7 with GDAL/OGR 2.1.1 (installed with osgeo4w) using the following ed8807c

Layer source for the vector geodatabase (source is incomplete and ogr2ogr command line is wrong):
polygon layer: C:\\Users\\jgu\\Desktop\\vector.gdb

Layer sources for the vector2 geodatabase (both layers have complete layer sources, ogr2ogr command lines are both correct):
point layer: C:\\Users\\jgu\\Desktop\\vector2.gdb|layername=testpoint
polygon layer: C:\\Users\\jgu\\Desktop\\vector2.gdb|layername=testpolygon

Results for 2.16.3 with GDAL/OGR 2.1.1 (installed with osgeo4w)

Layer source for the vector geodatabase (source is incomplete and ogr2ogr command line is wrong):
polygon layer: C:\\Users\\jgu\\Desktop\\vector.gdb

Layer sources for the vector2 geodatabase (sources are incomplete, ogr2ogr command lines are both wrong):
point layer: C:\\Users\\jgu\\Desktop\\vector2.gdb|layerid=1
polygon layer: C:\\Users\\jgu\\Desktop\\vector2.gdb

NOTE: the "layername=" to "layerid=" change was introduced in 2016-06-30, according to ChangeLog, to fix #15168

Taking it back, it doesn't look like #15168 has to do with this. Must have been a change in the geodatabase loader, to use layerid instead of layername. OGR provider supports both and never rewrites the uri. Even allows having both in the uri, giving precedence to layername if present.

Pull request ready for tests: https://github.com/qgis/QGIS/pull/3605

Great! Thanks a lot!

Of course you can.

btw, it looks like "convert format" tool is still suffering the same bug - are you aware of a separate ticket for that ?

Apparently most of the OGR tools in Processing are also having the same problem (I've just tried with buffer, clip, convert, etc.)

I'm not aware of a separate ticket...

Also fixed for 2.14.8

test introduced to fix this issue started to fail due different factors:

1) it fail in case data and tmp are in different filesystem (due to hard link nature).
A proposed patch here: https://github.com/qgis/QGIS/pull/5151

2) in https://github.com/qgis/QGIS/pull/5144 you can find reports that fail in Travis and in different test configurations