Feature request #15012
Hub Distance should use spatial index
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Normal | ||
| Assignee: |  Victor Olaya | ||
| Category: | Processing/QGIS | ||
| Pull Request or Patch supplied: | No | Resolution: | |
| Easy fix?: | No | Copied to github as #: | 22959 |
Description
Hub distance in Processing (https://github.com/qgis/QGIS/blob/master/python/plugins/processing/algs/qgis/HubDistance.py) is very slow because it does not take advantage of spatial indexing.
Associated revisions
[processing] speedup Hub distance algorithm (fix #15012)
[processing] speedup Hub distance algorithm (fix #15012)
(cherry picked from commit e0c9733f6482f184aeeff1339fafef210d1a0709)
Conflicts:
python/plugins/processing/algs/qgis/HubDistance.py
History
#1
Updated by Anita Graser almost 8 years ago
What's the best way to use a spatial index in a Processing script?
This does not take selection and layer filters into account:
index = QgsSpatialIndex(layerHubs.getFeatures())
#2
Updated by Nyall Dawson almost 8 years ago
Anita - what do you mean by "layer filters"?
#3
Updated by Anita Graser almost 8 years ago
Hi Nyall, I meant the layer's "provider feature filter" is ignored by layer.getFeatures(). (Btw, I don't think this was always the case in the past.)
#4
Updated by Nyall Dawson almost 8 years ago
Anita - I can't reproduce that. What's the data source? It's definitely a bug and it should be respected, and there's a even a bunch of unit tests to ensure that...
#5
Updated by Anita Graser almost 8 years ago
Sorry, I got something wrong here. Will open a new ticket when I find the source of my issue ... I had some issue mixing
processing.tools.vector.features(layer)
and
layer.getFeatures()
...
Anyway, back to the main topic: What's the recommended way to implement a spatial index in Processing algorithms?
#6
Updated by Nyall Dawson almost 8 years ago
I'd just do (psuedocode)
If using selected features:
index = QgsSpatialIndex(layerHubs.selectedFeaturesIterator())
Else:
index = QgsSpatialIndex(layerHubs.getFeatures())
#7
Updated by Alexander Bruy almost 8 years ago
- Status changed from Open to Closed
Fixed in changeset e0c9733f6482f184aeeff1339fafef210d1a0709.