Feature request #1473

3dz/3dm/4d support

Added by Jürgen Fischer over 8 years ago. Updated almost 2 years ago.

Status:Closed
Priority:Low
Assignee:Jürgen Fischer
Category:Vectors
Pull Request or Patch supplied:No Resolution:
Easy fix?:No

Description

attached a patch that add 3dz/3dz/4d vector support to core and the postgres provider.

sampletracks.tar.gz - Shapefile with Z and M Coordinates (24 KB) bitner -, 01/06/2011 11:56 AM


Related issues

Related to QGIS Application - Bug report #12310: Inconsistent handling of 3D and 4D postgis data Open 03/04/2015

History

#1 Updated by Martin Dobias over 8 years ago

Hi Juergen, I've took a brief look on your patch - I see there's quite big amount of work in it! :)

From the technical side, may I suggest you to leave QgsPoint as class for 3D points (X,Y,Z) and derive QgsPointM class from it which would operate also with M coordinates? I have the impression that these 'measure' dimension is used so rarely that it would cause unnecessary memory overhead in usual case.

Martin

#2 Updated by Paolo Cavallini over 8 years ago

Would this be the right time to apply this patch to svn?

#3 Updated by Jürgen Fischer over 8 years ago

I was about to update the patch - but it has grown to large to attach.
I uploaded it to http://buten.norbit.de/~jef/2d+.diff.

The patch now contains rewritten WKB parsing and creation code and uses QVector instead of QList to keep points. It reduces the need for reallocations and copying of memory.

#4 Updated by Jürgen Fischer over 8 years ago

Replying to [comment:4 jef]:

I uploaded it to http://buten.norbit.de/~jef/2d+.diff.

updated the patch to ddd7c8b0 (SVN r10067)

#5 Updated by Giovanni Manghi about 8 years ago

If the patch has been applied can I close this?

#6 Updated by Giovanni Manghi about 8 years ago

  • Resolution set to fixed
  • Status changed from Open to Closed

The patch should have been applied, so I'm closing this ticket. Reopen if necessary.

#7 Updated by Jürgen Fischer about 8 years ago

  • Resolution deleted (fixed)
  • Status changed from Closed to Feedback

this patch has not been applied.

#8 Updated by Jürgen Fischer about 8 years ago

Replying to [comment:9 jef]:

this patch has not been applied.

I've no application for 2d+ data - and therefore this hasn't been tested enough to be applied.

#9 Updated by Giovanni Manghi about 8 years ago

Replying to [comment:10 jef]:

Replying to [comment:9 jef]:

this patch has not been applied.

I've no application for 2d+ data - and therefore this hasn't been tested enough to be applied.

Hi Jürgen,

thanks for the feedback. Is this on the developers agenda for the next future?

#10 Updated by bitner - over 7 years ago

I am happy to provide either testing or sample datasets for this feature if it gets pulled back up. This is very important for anyone who needs to carry through Z and M data even if they are not using it in all situations.

#11 Updated by Paolo Cavallini over 7 years ago

bitner (or others), please provide sample data for testing and eventually apply the patch

#12 Updated by bitner - over 6 years ago

Replying to [comment:13 pcav]:

bitner (or others), please provide sample data for testing and eventually apply the patch

Just now saw this.... Attaching a shapefile that has Z and M Coordinates. (shp2pgsql will bring it in with Z and M dimensions intact -- OGR will drop them)

#13 Updated by Sandro Santilli about 6 years ago

Note that as of postgis 2.0 (current postgis trunk) chances are you won't even see columns containing geometries with 3dZ, 3dM or 4d coordinates. Didn't really test but there's been changes in the geometry_columns.type field...

#14 Updated by Alister Hood about 6 years ago

  • Pull Request or Patch supplied set to No

This seems like a feature that would be good to have in QGIS 2.0
A lot of the existing patch fails to apply to the current code. I presume someone would need to work through it all manually - you haven't got a local branch in sync with the current trunk or anything, have you Jürgen?

#15 Updated by Giovanni Manghi almost 6 years ago

  • Target version changed from Version 1.7.0 to Version 1.7.4

#16 Updated by Jürgen Fischer almost 6 years ago

  • Target version changed from Version 1.7.4 to Version 2.0.0

#17 Updated by Pirmin Kalberer almost 5 years ago

  • Target version changed from Version 2.0.0 to Future Release - Nice to have

#18 Updated by Jürgen Fischer about 3 years ago

  • Status changed from Feedback to Open

#19 Updated by Jürgen Fischer over 2 years ago

wkb parsing part "merged" in 6bbd17c217e405db9ccfae629b0cc86ff28ca05b

#20 Updated by Jürgen Fischer almost 2 years ago

  • Status changed from Open to Closed

superceded by new geometry classes.

Also available in: Atom PDF