Bug report #14051

Symbol selector dialog: "lock layer's colors" button should have only two states

Added by Harrissou Santanna over 3 years ago. Updated over 3 years ago.

Status:Closed
Priority:Normal
Assignee:-
Category:Symbology
Affected QGIS version:2.12.0 Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:22062

Description

Open the symbol selector dialog,
add new symbol layers to the symbol tree
and try to lock some of them with the "lock layer's color" button at the bottom.
When clicked, the button stays unlocked but with a colored background. You need to choose another symbol in the tree and come back to the symbol to see the change (locked state of the button).
Same behaviour when you want to unlock.

I think the new state of the button should be triggered as soon as the button is clicked. No need for an intermediate state that doesn't help to know the current state and just imho leads to confusion.

Associated revisions

Revision 9af79862
Added by Sebastian Dietrich over 3 years ago

[SymbolSelector] display correct icons when button LockLayerColors is active
(fixes #14051)

Revision f3d1f8b8
Added by Nyall Dawson over 3 years ago

Merge pull request #2655 from SebDieBln/FixButtonLockLayerColors

[SymbolSelector] Display correct icons when button LockLayerColors is active (fixes #14051)

History

#1 Updated by Sebastian Dietrich over 3 years ago

The icon is wrongly displayed when the button has the focus. It always displays the icon for the state unlocked in this case.

See PR 2655 for a solution.

#2 Updated by Nyall Dawson over 3 years ago

  • Status changed from Open to Closed

Also available in: Atom PDF