Bug report #14048

Importing symbols in Style Library doesn't always use the group name entered

Added by Harrissou Santanna over 3 years ago. Updated over 3 years ago.

Status:Closed
Priority:Normal
Assignee:-
Category:-
Affected QGIS version:2.12.0 Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:22059

Description

When importing symbols into Style library, there's a field to indicate the group to which symbols belong.
  • If you enter an existing group name, symbols will go there.
  • If the field is empty, the imported symbols will be grouped in a new group named as the imported file.
  • If you enter a name of a group that doesn't exist, imported file name will still be used instead of the name entered.

Given that case 2 shows that it's possible to create a new group from this dialog, I think in the case 3, it should create the group with the name typed.

Associated revisions

Revision 284704ab
Added by Sebastian Dietrich over 3 years ago

[StyleManager] Respect the entered group name when importing symbols
(fixes #14048)

Revision 8d105ff8
Added by Nyall Dawson over 3 years ago

Merge pull request #2649 from SebDieBln/StyleManager_ImportGroupName

[StyleManager] Respect entered groupname when importing symbols (fixes #14048)

History

#1 Updated by Sebastian Dietrich over 3 years ago

Harrissou Santanna wrote:

  • If the field is empty, the imported symbols will be grouped in a new group named as the imported file.
  • If you enter a name of a group that doesn't exist, imported file name will still be used instead of the name entered.

This is not the whole truth. The name used is the name that was in the combo-box before the user edited it. If you select an existing group foo-group and delete its name from the combobox or change it, the symbols will be imported to foo-group.

So while the combobox actually allows editing, this is not taken into account by the import routine.

#2 Updated by Sebastian Dietrich over 3 years ago

See PR 2649 for a solution that additionally allows importing symbols without adding them to a group.

#3 Updated by Nyall Dawson over 3 years ago

  • Status changed from Open to Closed

Also available in: Atom PDF