Bug report #9621

Remove Topology Checker tolerance column from rule settings

Added by Darren Kavanagh over 6 years ago. Updated over 2 years ago.

Status:Closed
Priority:Normal
Assignee:-
Category:C++ plugins/Topology checker
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:18195

Description

Could the tolerance column be removed from the Topology Checker's 'Topology Rule Settings' table (see attached screen capture) or at least be non-editable? From my testing and code review, the tolerance functionality does not appear to be implemented. It is confusing to have the option both listed and editable.

Tolerance.png (71.3 KB) Darren Kavanagh, 2014-02-22 05:22 PM

Associated revisions

Revision 8ebd47bf
Added by Nyall Dawson over 2 years ago

[needs-docs] Drop unused/misleading 'tolerance' setting from topology
checker

Fixes #9621

Revision bed5c763
Added by Nyall Dawson over 2 years ago

[needs-docs] Drop unused/misleading 'tolerance' setting from topology
checker

Fixes #9621

(cherry-picked from 8ebd47b)

History

#1 Updated by Giovanni Manghi over 6 years ago

  • Category set to C++ Plugins
  • Affected QGIS version changed from 2.0.1 to master

#2 Updated by Antonio Locandro over 6 years ago

Still present in master, I would however like the functionality to be implemented instead of making the tolerance not editable. I have a series of layers in which I have an acceptable tolerance for error, but topology check is giving me all with errors

#3 Updated by Jürgen Fischer about 6 years ago

  • Category changed from C++ Plugins to C++ plugins/Topology checker

#4 Updated by Giovanni Manghi over 3 years ago

  • Regression? set to No
  • Easy fix? set to No

#5 Updated by Darren Kavanagh over 2 years ago

This issue still exists in version 3.

#6 Updated by Darren Kavanagh over 2 years ago

Reviewing this bug after a gap of a few years - tolerance is used for two rules that are excluded from compilation but not any of the compiled and available rules. See topolTest.cpp in the repo.

#7 Updated by Nyall Dawson over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

Also available in: Atom PDF