Bug report #8587

Show/Hide labels command doesn't work any more

Added by Alessandro Ciali about 7 years ago. Updated about 7 years ago.

Status:Closed
Priority:Normal
Assignee:Larry Shaffer
Category:Labelling
Affected QGIS version:master Regression?:No
Operating System:windows Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:17329

Description

Selecting Show/Hide label tool and clicking on a labeled feature results in no change and the following message log under Qt:

QUndoStack::endMacro(): no matching beginMacro()

the only way to hide the label is from change label menu

Associated revisions

Revision 5f61dd12
Added by Larry Shaffer about 7 years ago

Fix #8587, show/hide labels tool throws Qt warning

History

#1 Updated by Giovanni Manghi about 7 years ago

  • Status changed from Open to Feedback

Works fine here, tested on master on both Linux and Windows. Can you attach sample data?

#2 Updated by Larry Shaffer about 7 years ago

  • Priority changed from Severe/Regression to Normal
  • Assignee set to Larry Shaffer

Hi Alessandro,

I can not verify on Mac either. However, I was able to reproduce the logging of the 'QUndoStack::endMacro()...' message.

Please hover over the tool and read the tool tip. The tool's behavior is toggled by whether the Shift key is modifying the tool's click/marquee. If the label is already being shown, and you try to show it again, the message shows up in the log viewer (harmless, though still a bug). The opposite, holding Shift key to hide a label that is already hidden, does not present the message.

I will look into fixing the logged message ASAP. Thanks for reporting.

#3 Updated by Larry Shaffer about 7 years ago

  • Status changed from Feedback to Closed

#4 Updated by Alessandro Ciali about 7 years ago

Hi all,
I have to apologise about the bug I opened. Now I undestand: I was clicking on the feature with Ctrl Key. Qt log convinced me that there was something wrong with the tool.
Thank you for your support.

Also available in: Atom PDF