Bug report #8484

QGIS Server: Exclude composers in OWS tab does not work

Added by Andreas Neumann over 6 years ago. Updated about 6 years ago.

Status:Closed
Priority:High
Assignee:Marco Hugentobler
Category:QGIS Server
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:17250

Description

In the current QGIS server, if one uses a list of "Exclude composers" in the OWS tab, QGIS server lists only the excluded composers and not the composers the map author actually wants. So it acts as a white list and not as a black list.

Thank you for having a look at the problem!

History

#1 Updated by Marco Hugentobler over 6 years ago

  • Assignee set to Marco Hugentobler

#2 Updated by René-Luc ReLuc about 6 years ago

Will this bug be closed before QGIS 2 branching ?

#3 Updated by René-Luc ReLuc about 6 years ago

Hi Marco,

I have threw a glance at the code and the list of excluded composers is stored in the element WMSComposerList.

To fix this bug, we have several solutions :
  1. Change the UI string and comments
  2. Change the element name

Which has your preference ?

#4 Updated by Marco Hugentobler about 6 years ago

Hi René-Luc

My preference is to change the element name and the behaviour (currently whitelist -> blacklist). I think it is more usefull to have a list of not-published compositions rather than explicitely publishing every composition.

#5 Updated by René-Luc ReLuc about 6 years ago

OK, can I propose a patch or directly update master ?

#6 Updated by Andreas Neumann about 6 years ago

Hi,

Yes - the blacklist behaviour was already in place before this bug appeared. Also, I think the blacklist is what administrators want. Easier to maintain. Most of the composers would be public except some selected internal ones.

Thanks for providing the patch.

Andreas

#7 Updated by Marco Hugentobler about 6 years ago

OK, can I propose a patch or directly update master ?

Could you make a pull request on github?

#8 Updated by René-Luc ReLuc about 6 years ago

  • % Done changed from 0 to 100
  • Pull Request or Patch supplied changed from No to Yes

#9 Updated by Marco Hugentobler about 6 years ago

  • Status changed from Open to Closed

Works nicely, pushed to master branch. Thanks, René-Luc!

Also available in: Atom PDF