https://issues.qgis.org/https://issues.qgis.org/favicon.ico2013-08-20T06:53:06ZQGIS Issue TrackingQGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=441712013-08-20T06:53:06ZMarco Hugentoblermarco.hugentobler@sourcepole.ch
<ul><li><strong>Assignee</strong> set to <i>Marco Hugentobler</i></li></ul> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444752013-09-03T21:50:38ZRené-Luc ReLucrldhont@3liz.com
<ul></ul><p>Will this bug be closed before QGIS 2 branching ?</p> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444762013-09-03T22:27:30ZRené-Luc ReLucrldhont@3liz.com
<ul></ul><p>Hi Marco,</p>
<p>I have threw a glance at the code and the list of excluded composers is stored in the element WMSComposerList.</p>
To fix this bug, we have several solutions :
<ol>
<li>Change the UI string and comments</li>
<li>Change the element name</li>
</ol>
<p>Which has your preference ?</p> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444772013-09-03T23:00:15ZMarco Hugentoblermarco.hugentobler@sourcepole.ch
<ul></ul><p>Hi René-Luc</p>
<p>My preference is to change the element name and the behaviour (currently whitelist -> blacklist). I think it is more usefull to have a list of not-published compositions rather than explicitely publishing every composition.</p> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444782013-09-03T23:03:28ZRené-Luc ReLucrldhont@3liz.com
<ul></ul><p>OK, can I propose a patch or directly update master ?</p> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444792013-09-03T23:24:06ZAndreas Neumann
<ul></ul><p>Hi,</p>
<p>Yes - the blacklist behaviour was already in place before this bug appeared. Also, I think the blacklist is what administrators want. Easier to maintain. Most of the composers would be public except some selected internal ones.</p>
<p>Thanks for providing the patch.</p>
<p>Andreas</p> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444802013-09-03T23:29:25ZMarco Hugentoblermarco.hugentobler@sourcepole.ch
<ul></ul><blockquote>
<p>OK, can I propose a patch or directly update master ?</p>
</blockquote>
<p>Could you make a pull request on github?</p> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444812013-09-03T23:34:19ZRené-Luc ReLucrldhont@3liz.com
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Pull Request or Patch supplied</strong> changed from <i>No</i> to <i>Yes</i></li></ul><p>Pull request made :<br /><a class="external" href="https://github.com/qgis/Quantum-GIS/pull/867">https://github.com/qgis/Quantum-GIS/pull/867</a></p> QGIS Application - Bug report #8484: QGIS Server: Exclude composers in OWS tab does not workhttps://issues.qgis.org/issues/8484?journal_id=444832013-09-04T00:28:41ZMarco Hugentoblermarco.hugentobler@sourcepole.ch
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Works nicely, pushed to master branch. Thanks, René-Luc!</p>