Bug report #7533

field calculator is much slower on master than in 1.8

Added by Giovanni Manghi over 6 years ago. Updated over 6 years ago.

Status:Closed
Priority:Severe/Regression
Assignee:-
Category:Vectors
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:16477

Description

~3000 records

QGIS 1.8:
New field -> $area: ~2s
Update -> $perimeter: ~2s
Update -> $id: <2s

QGIS master:
New field -> $area: ~32s
Update -> $perimeter: ~32s
Update -> $id: ~14s

Associated revisions

Revision a21fc5a7
Added by Matthias Kuhn over 6 years ago

[FIX #7533] Field calculator is slow
Set the QgsDistanceArea only once and not for every loop cycle.
QgsCoordinateReferenceSystem::loadFromDb takes very long.

Revision a150865e
Added by Jürgen Fischer over 6 years ago

Merge pull request #510 from matthias-kuhn/field-calculator-perf

[FIX #7533] Field calculator is slow

History

#1 Updated by Matthias Kuhn over 6 years ago

  • Status changed from Open to In Progress

I've got a patch for this ready. Hopefully it is reviewed soon.

https://github.com/qgis/Quantum-GIS/pull/510

Giovanni:
You could help by doing your profiling with this patch again.

#2 Updated by Jürgen Fischer over 6 years ago

  • Status changed from In Progress to Closed

#3 Updated by Matthias Kuhn over 6 years ago

Giovanni, could you still do the profiling to verify this solves the issue. Thank you.

#4 Updated by Giovanni Manghi over 6 years ago

Matthias Kuhn wrote:

Giovanni, could you still do the profiling to verify this solves the issue. Thank you.

really, really improved. Thanks a lot Matthias!

Also available in: Atom PDF