[FIX #7533] Field calculator is slow

m-kuhn · m-kuhn · commit a21fc5a73d92 · 2013-04-08T21:07:16.000+02:00
Set the QgsDistanceArea only once and not for every loop cycle.
QgsCoordinateReferenceSystem::loadFromDb takes very long.
diff --git a/src/app/qgsfieldcalculator.cpp b/src/app/qgsfieldcalculator.cpp
@@ -94,6 +94,7 @@ void QgsFieldCalculator::accept()
 
   QString calcString = builder->expressionText();
   QgsExpression exp( calcString );
+  exp.setGeomCalculator( myDa );
 
   if ( !mVectorLayer || !mVectorLayer->isEditable() )
     return;
@@ -173,8 +174,6 @@ void QgsFieldCalculator::accept()
     }
 
     exp.setCurrentRowNumber( rownum );
-    exp.setGeomCalculator( myDa );
-
     QVariant value = exp.evaluate( &feature );
     if ( exp.hasEvalError() )
     {

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ void QgsFieldCalculator::accept()`
`94`	`94`
`95`	`95`	`QString calcString = builder->expressionText();`
`96`	`96`	`QgsExpression exp( calcString );`
	`97`	`+ exp.setGeomCalculator( myDa );`
`97`	`98`
`98`	`99`	`if ( !mVectorLayer \|\| !mVectorLayer->isEditable() )`
`99`	`100`	`return;`
`@@ -173,8 +174,6 @@ void QgsFieldCalculator::accept()`
`173`	`174`	`}`
`174`	`175`
`175`	`176`	`exp.setCurrentRowNumber( rownum );`
`176`		`- exp.setGeomCalculator( myDa );`
`177`		`-`
`178`	`177`	`QVariant value = exp.evaluate( &feature );`
`179`	`178`	`if ( exp.hasEvalError() )`
`180`	`179`	`{`