Bug report #6410
expanded layer collapses when clicking on the 'ok' or 'apply' buttons from the layer properties window
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Normal | ||
| Assignee: | - | ||
| Category: | Map Legend | ||
| Affected QGIS version: | master | Regression?: | No |
| Operating System: | Easy fix?: | No | |
| Pull Request or Patch supplied: | No | Resolution: | fixed/implemented |
| Crashes QGIS or corrupts data: | No | Copied to github as #: | 15663 |
Description
When clicking on the Layer Properties window's 'OK' or 'Apply' buttons, the layer item being edited will collapse (in the Layers' legend tree), irrespective of whether the user had the layer item collapsed or expanded.
IMO, the right behavior should be for the collapsed or expanded state of the layer item to be respected when leaving the layer properties window. QGIS was applying such a behavior until it regressed in v1.8. This bug is present in QGIS master.
History
#1
Updated by Giovanni Manghi about 12 years ago
- Status changed from Open to Feedback
So this worked fine in 1.7.4 and regressed in 1.8?
#2
Updated by Paolo Cavallini about 12 years ago
- Subject changed from expended layer collapses when clicking on the 'ok' or 'apply' buttons from the layer properties window to expanded layer collapses when clicking on the 'ok' or 'apply' buttons from the layer properties window
#3
Updated by Mathieu Pellerin - nIRV about 12 years ago
Giovanni, yes, it works fine in 1.7.4 and regressed in 1.8. I've just downloaded a 1.7.4 build to make sure it worked then.
#4
Updated by Giovanni Manghi about 12 years ago
- Priority changed from Normal to Severe/Regression
nirvn - wrote:
Giovanni, yes, it works fine in 1.7.4 and regressed in 1.8. I've just downloaded a 1.7.4 build to make sure it worked then.
if is not a regression (if also in 1.7.4 does not work as expected) please remove the "blocker" tag
#5
Updated by Mathieu Pellerin - nIRV about 12 years ago
Blocker should stay as it did work in 1.7.4. Thanks for setting it up.
#6
Updated by Mathieu Pellerin - nIRV about 12 years ago
Hmm, there's been movement. Using latest qgis-dev windows build (3398341), the unwanted collapse is gone when changing style through the layer properties window! Wouhou.
That said, copy / pasting a style using the right click menu item will still result in unwanted collapse of expanded layer items.
Who deserves to be credited for this improvement? :)
#7
Updated by Giovanni Manghi almost 12 years ago
- Status changed from Feedback to Open
- Target version set to Version 2.0.0
nirvn - wrote:
Hmm, there's been movement. Using latest qgis-dev windows build (3398341), the unwanted collapse is gone when changing style through the layer properties window! Wouhou.
I still see this wrong behavior in the latest master
#8
Updated by Mathieu Pellerin - nIRV over 11 years ago
Good news everyone! Clicking on Apply or Ok from the Layer Property window doesn't collapse layer items anymore.
There are two remaining actions that still triggers this (mis)behavior:
- Paste Style layer item right-click menu
- Clicking on Ok from the layer filter query window
Since this ticket was only covering layer property ok/apply, it could be closed. But the above two remaining collapses should also be dealt with :)
#9
Updated by Mathieu Pellerin - nIRV over 11 years ago
- Priority changed from Severe/Regression to Normal
Lowering priority.
#10
Updated by Jürgen Fischer over 10 years ago
- Target version changed from Version 2.0.0 to Future Release - Lower Priority
#11
Updated by Médéric RIBREUX almost 9 years ago
- Status changed from Open to Feedback
Hello, bug triage...
the last part of the bug seems to be fixed (at least in QGIS 2.13 master): When I apply style or use the "Filter..." window, graduated/categorized layers are not collapsed nor expanded (initial state isn't modified).
Can you confirm this ?
#12
Updated by Mathieu Pellerin - nIRV almost 9 years ago
- Resolution set to fixed/implemented
- Status changed from Feedback to Closed