Bug report #21259

Geometry Checker Crashes

Added by Jeff Pickles over 5 years ago. Updated over 5 years ago.

Status:Closed
Priority:High
Assignee:Alessandro Pasotti
Category:C++ plugins/Geometry Checker
Affected QGIS version:3.5(master) Regression?:No
Operating System:Any Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:fixed/implemented
Crashes QGIS or corrupts data:Yes Copied to github as #:29077

Description

New install of QGIS 3.4.4 ( 2/12/2019) on Windows 10 with current updates as of 2/13/2019. Working with a polygon file with many overlaps that we need to clean up without deleting by intersection which will leave gaps. Using geometry checker to find overlaps, set to create a new geopackage in a new folder location all on local drives. No Network issues. Geom Checker produces an output and will run the fix process on a single polygon but then crashes if we try to fix them all or if we try to close geometry checker after the first fix to inspect it. We have not been able to really look at the results but it looks like its just redrawing the order of the overlap on screen and not removing the overlap with the shortest side as the rule is set to.

polygons.cpg (5 Bytes) Jeff Pickles, 2019-02-13 04:38 PM

polygons.dbf (5.68 KB) Jeff Pickles, 2019-02-13 04:38 PM

polygons.prj (555 Bytes) Jeff Pickles, 2019-02-13 04:38 PM

polygons.qpj (769 Bytes) Jeff Pickles, 2019-02-13 04:38 PM

polygons.shx (3.84 KB) Jeff Pickles, 2019-02-13 04:38 PM

polygons.shp (669 KB) Jeff Pickles, 2019-02-13 04:38 PM

test.cpg (5 Bytes) Jeff Pickles, 2019-02-14 07:07 PM

test.dbf (165 Bytes) Jeff Pickles, 2019-02-14 07:07 PM

test.qpj (769 Bytes) Jeff Pickles, 2019-02-14 07:07 PM

test.prj (555 Bytes) Jeff Pickles, 2019-02-14 07:07 PM

test.shx (172 Bytes) Jeff Pickles, 2019-02-14 07:07 PM

test.shp (2.87 KB) Jeff Pickles, 2019-02-14 07:07 PM


Related issues

Duplicates QGIS Application - Bug report #21231: QGIS crashes using the geometry checker Closed 2019-02-11

Associated revisions

Revision 1f08a061
Added by Alessandro Pasotti over 5 years ago

Geom checker plugin: don't crash if feedback is 0x0

Fixes #21259

History

#1 Updated by Jeff Pickles over 5 years ago

Additional Testing shows the error may be occurring when geom checker tries to save the results as geopackage or shapefile were tested. Both file types cause a QGIS crash on exporting the file.

#2 Updated by Jeff Pickles over 5 years ago

User Feedback

Using geometry checker on a polygon file to find overlap, gaps, and valid geometry. Geom Checker runs and creates the results tab. Then QGIS crashes if we do anything else. If we fix one error, try to export the results to a new file or fix all the errors, QGIS crashes.

Report Details

Crash ID: 9c5c1aa2ac9800a0433dd83f38e36e4a41cb1907

Stack Trace

QgsFeaturePool::layer :
CPLStringList::size :
CPLStringList::size :
QMetaObject::activate :
QAbstractButton::clicked :
QAbstractButton::click :
QAbstractButton::mouseReleaseEvent :
QWidget::event :
QApplicationPrivate::notify_helper :
QApplication::notify :
QgsApplication::notify :
QCoreApplication::notifyInternal2 :
QApplicationPrivate::sendMouseEvent :
QSizePolicy::QSizePolicy :
QSizePolicy::QSizePolicy :
QApplicationPrivate::notify_helper :
QApplication::notify :
QgsApplication::notify :
QCoreApplication::notifyInternal2 :
QGuiApplicationPrivate::processMouseEvent :
QWindowSystemInterface::sendWindowSystemEvents :
QEventDispatcherWin32::processEvents :
CallWindowProcW :
DispatchMessageW :
QEventDispatcherWin32::processEvents :
qt_plugin_query_metadata :
QEventLoop::exec :
QCoreApplication::exec :
main :
BaseThreadInitThunk :
RtlUserThreadStart :

QGIS Info
QGIS Version: 3.4.4-Madeira
QGIS code revision: f6ddc62fdb
Compiled against Qt: 5.11.2
Running against Qt: 5.11.2
Compiled against GDAL: 2.4.0
Running against GDAL: 2.4.0

System Info
CPU Type: x86_64
Kernel Type: winnt
Kernel Version: 10.0.17134

#3 Updated by Jeff Pickles over 5 years ago

Also same failures when running geom checker on a simple test file which we created by drawing several overlapping polygons, internal polygon and polygon with shared vertex.

#4 Updated by Alessandro Pasotti over 5 years ago

  • Assignee set to Alessandro Pasotti

#5 Updated by Alessandro Pasotti over 5 years ago

  • Resolution set to fixed/implemented
  • Status changed from Open to In Progress
  • Affected QGIS version changed from 3.4.4 to 3.5(master)
  • Operating System changed from windows 10 pro to Any
  • Pull Request or Patch supplied changed from No to Yes

#6 Updated by Alessandro Pasotti over 5 years ago

  • % Done changed from 0 to 100
  • Status changed from In Progress to Closed

#7 Updated by Alessandro Pasotti over 5 years ago

Also available in: Atom PDF