Bug report #20158

Moving segments after range selection of vertices destroys topology

Added by Andreas Wicht almost 2 years ago. Updated almost 2 years ago.

Status:Closed
Priority:High
Assignee:-
Category:Digitising
Affected QGIS version:3.2.3 Regression?:No
Operating System:Windows 10 / Ubuntu 18.04 Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:27979

Description

When using the vertex range selection, in order to select several segments which are supposed to be moved, the operation destroys the toplogy of the layer.
When selecting the vertices by dragging a rectangle and one feature is selected, the operation also fails.
When selecting the vertices by dragging a rectangle without any selection it works just fine.

The attached gifs should illustrate the issue.

I am not sure if this issue should actually be split into two separate ones or if it has the same cause in the code base.

segment_1.gif - rectangle - working (276 KB) Andreas Wicht, 2018-10-18 03:04 PM

segment_2_fail.gif - range selection 1 - fails (223 KB) Andreas Wicht, 2018-10-18 03:04 PM

segment_3_fail.gif - range selection 2 - fails (216 KB) Andreas Wicht, 2018-10-18 03:04 PM

segment_4_fail.gif - rectangle with selection - fails (247 KB) Andreas Wicht, 2018-10-18 03:04 PM


Related issues

Duplicates QGIS Application - Bug report #18190: vertex editor don't honour topological editing when used ... Closed 2018-02-23

Associated revisions

Revision 93e737e4
Added by Martin Dobias almost 2 years ago

[vertex tool] Fix topo editing when moving vertices/edges (fixes #20158)

- when some "extra" vertices are selected when moving a vertex, their coincident
vertices will be also moved (#20158)
- when moving an edge, coincident vertices to its endpoints will be also moved
- new tests to cover the above scenarios
- made the code hopefully easier to read

Revision 2f5a87fd
Added by Martin Dobias almost 2 years ago

[vertex tool] Fix topo editing when moving vertices/edges (fixes #20158)

- when some "extra" vertices are selected when moving a vertex, their coincident
vertices will be also moved (#20158)
- when moving an edge, coincident vertices to its endpoints will be also moved
- new tests to cover the above scenarios
- made the code hopefully easier to read

(cherry picked from commit 93e737e4bf50d03fa20316ec8da66db99e32c5cd)

History

#2 Updated by Martin Dobias almost 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

#3 Updated by Martin Dobias almost 2 years ago

  • Duplicates Bug report #18190: vertex editor don't honour topological editing when used with a feature selection AND a node selection added

Also available in: Atom PDF