Bug report #18461

disabled providers are showing up in modeler

Added by Rashad Kanavath over 2 years ago. Updated over 2 years ago.

Status:Closed
Priority:Normal
Assignee:Victor Olaya
Category:Processing/Modeller
Affected QGIS version:master Regression?:Yes
Operating System:Linux Easy fix?:Yes
Pull Request or Patch supplied:Yes Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:26349

Description

Disabled providers are shown in modeler but not in processingtoolbox.
Steps to reproduce:
Disable one or more of external providers(SAGA/GDAL/GRASS GIS) in processing plugin's settings.

ProcessingToolBox tree updates list of providers and algorithms immediately.
But when you open modeler you can see disabled providers (empty treeitem).
Such providers are visible with an empty text and no child algorithms. But this is confusion from user point of view.

diff below.

index 2b48b4094e..c299a957e0 100644
--- a/python/plugins/processing/modeler/ModelerDialog.py
+++ b/python/plugins/processing/modeler/ModelerDialog.py
@@ -711,8 +711,8 @@ class ModelerDialog(BASE, WIDGET):
                     if isinstance(child, TreeProviderItem):
                         if child.text(0) > providerItem.text(0):
                             break
-
-                self.algorithmTree.insertTopLevelItem(i + 1, providerItem)
+                if providerItem.provider.isActive():
+                    self.algorithmTree.insertTopLevelItem(i + 1, providerItem)

     def addAlgorithmsFromProvider(self, provider, parent):
         groups = {}

ok?

Associated revisions

Revision 092557b1
Added by Alexander Bruy over 2 years ago

[processing] correctly handle inactive providers in the modeler (fix #18461)

Revision 6a027e7a
Added by Alexander Bruy over 2 years ago

[processing] correctly handle inactive providers in the modeler (fix #18461)

(cherry picked from commit 092557b16a0186cef6850a9d4ec38c9308725c1f)

History

#1 Updated by Alexander Bruy over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

Also available in: Atom PDF