Bug report #18046
Adding new vertices ignores topological editing
| Status: | Closed | ||
|---|---|---|---|
| Priority: | High | ||
| Assignee: | - | ||
| Category: | Digitising | ||
| Affected QGIS version: | 3.3(master) | Regression?: | Yes |
| Operating System: | Easy fix?: | No | |
| Pull Request or Patch supplied: | No | Resolution: | |
| Crashes QGIS or corrupts data: | No | Copied to github as #: | 25942 |
Description
Given two polygons which share a boundary and the user would like to insert a new node (clicking the '+' between two existing nodes), the node is only inserted in one polygon and therefore breaks the topological relationship (producing a gap/overlap).
Moving existing nodes works fine, as the same node is moved for both polygons. Same with deleting.
Master 1a117ct080 on Win 7 via osgeo4w installer
Snapping: on
Enable Topological Editing: on
Snapping on intersection: on
Avoid intersection: on
Tolerance 10px
Related issues
Associated revisions
[vertex tool] Respect topo editing when adding a vertex (fixes #18046)
When adding a vertex to a segment that is coincident with some other
segments and topological editing is enabled, vertex tool will now correctly
add new vertex also the coincident segments to preserve shared borders.
[vertex tool] Respect topo editing when adding a vertex (fixes #18046)
When adding a vertex to a segment that is coincident with some other
segments and topological editing is enabled, vertex tool will now correctly
add new vertex also the coincident segments to preserve shared borders.
(cherry picked from commit 5dd566455fa414ed93779564a3b272334bf42bd0)
History
#1
Updated by Harrissou Santanna about 6 years ago
Still the case in master (3.3)
Does it work in 2.18?
#2
Updated by Harrissou Santanna about 6 years ago
- Related to Bug report #18192: vertex editor doesn't honour topological editing when moving a segment added
#3
Updated by Harrissou Santanna about 6 years ago
- Related to Bug report #17331: new node tool topological editing added
#4
Updated by Giovanni Manghi about 6 years ago
- Priority changed from Normal to High
- Affected QGIS version changed from master to 3.3(master)
- Regression? changed from No to Yes
Harrissou Santanna wrote:
Still the case in master (3.3)
Does it work in 2.18?
it did indeed. Moreover in 2.* it was possible to double click on segment to add a node in a whatever position (not only in the middle of a segment). Also now when adding a node this is immediately selected and so moving the mouse moves the new node. I find the latter a usability regression, in 2.* adding nodes (wherever) with double clicks without need to reposition them immediately was a functionality that final users liked a lot.
#5
Updated by Giovanni Manghi about 6 years ago
- Operating System deleted (
Windows 7)
#6
Updated by Harrissou Santanna about 6 years ago
adding nodes (wherever) with double clicks without need to reposition them immediately was a functionality that final users liked a lot.
I can't agree more. I miss it too. If I recall correctly, this was one of the missing features pointed either in the QEP or its first implementations. And I thought it'd be fixed in later commits but... Maybe the use case was not clear/convincing enough...
#7
Updated by Giovanni Manghi about 6 years ago
I can't agree more. I miss it too. If I recall correctly, this was one of the missing features pointed either in the QEP or its first implementations. And I thought it'd be fixed in later commits but... Maybe the use case was not clear/convincing enough...
I think we should raise this in the dev mailing list. I can write there, agree?
#8
Updated by Andreas Wicht about 6 years ago
+1 from me
#9
Updated by Giovanni Manghi about 6 years ago
Andreas Wicht wrote:
+1 from me
https://github.com/qgis/QGIS-Enhancement-Proposals/issues/69#issuecomment-418085628
feel free to add more comments.
#10
Updated by Jürgen Fischer about 6 years ago
- Duplicated by Bug report #20137: Topological editing don't works as expected in QGIS Master added
#11
Updated by Martin Dobias about 6 years ago
#12
Updated by Martin Dobias about 6 years ago
- % Done changed from 0 to 100
- Status changed from Open to Closed
Applied in changeset qgis|5dd566455fa414ed93779564a3b272334bf42bd0.