QGIS » QGIS Application

Harrissou Santanna wrote:

Yes, the fix has to be done in the QGIS-Documentation Github repository if that's the question. But the "entry point" of the issue is experienced in the application: when clicking a Help button.

is there an issue filed on github? cheers!

Giovanni Manghi wrote:

is there an issue filed on github? cheers!

A kind of. See https://github.com/qgis/QGIS-Documentation/issues/1834

Harrissou Santanna wrote:

I'm not sure I said anything else, did I? I neither see anything wrong with the URL; you might mix the issues (see #17231 where I feel there's something to change in QGIS application side in the url construction).

Maybe I misunderstand you, but in the ticket you said

Harrissou Santanna wrote:

However, in its default implementation, it does not work.

which is not true. QGIS part works exactly in the same way as it should according to the QEP.

Alexander Bruy wrote:

Tested with German, French and Ukrainian locales, result always correct

Ukrainian: http://docs.qgis.org/2.99/uk/docs/user_manual/introduction/qgis_configuration.html#options
French: http://docs.qgis.org/2.99/fr/docs/user_manual/introduction/qgis_configuration.html#options
German: http://docs.qgis.org/2.99/de/docs/user_manual/introduction/qgis_configuration.html#options

Unless I misunderstand you, allow me to be really dubious about that... 2.99 hence testing (aka master) is an english only doc so I'm afraid I can't reach any of the translated pages you provide (see eg wrong_uk_url screenshot). And using my french system locale, it expects fr_FR instead of fr as you cited above.

I'm afraid you are confused with release and development stuff here. Of course, you can't reach any of these URL's because there is no (and never will be) localized documentation for master. We provide documentation only for releases and you should not transfer development URLs to the release version. But URLs constructed correctly, there is a valid sequence of version, locale and documentation chapters. May I ask you how will look URL for 3.0 release? Won't it be something like http://docs.qgis.org/3.0/fr/docs/user_manual/introduction/qgis_configuration.html#options? If yes, what is the problem?

Also why you expect fr_FR instead of fr? Documentation site use fr for French, not fr_FR. Same with other languages. If you mean that you get URL's with fr_FR, then please provide more information about you environment, because I'm unable to reproduce it on my system. That's why I asked

If issue exists, please provide exact steps to reproduce issue.

Based on the previous remark (only english is provided) I'd be tempted to say: just click any help button. But let me be verbose with some steps:

• switch to en-US language because even that one fails here (i think you might need to restart)
• click the help button of the Options dialog
• it'll try to open http://docs.qgis.org/2.99/en_US/docs/user_manual/introduction/qgis_configuration.html#options (note the language part, en_US instead of en )
• and you get a Not Found Page (see wrong_en_url screenshot)

Please, please, don't confuse development version and release version. Of course with development version you can't access localized docs because there is no localized docs for master. There is nothing wrong here and it was already discussed and explained several times. But if you want, you can access English version, just adjust your settings and remove locale from the base URL.

Harrissou Santanna wrote:

1/ when I do not override the system locale option, the language is retrieved as fr_FR as you can see in the locale_system screenshot. So when I hit the help button, the docs link is constructed with fr_FR (it's not me expecting that, it's what Firefox tries to open) instead of fr

2/ when I override it with the "American English" (I do not have "English" in the drop-down list) and I hit the Help button, I get links with en_US (I already sent the screenshot for that) instead of en

Hmm, which OS are you using? Because on Linux with default locale uk_UA.UTF-8 without overriding locale in QGIS settings I get correct URL. Also if I override locale either via QGIS settings or by defining different LC_* environment variables resulting URL still correct, no fr_FR or similar codes, only two-letter code.

Hmm, which OS are you using?

Windows 10

Seems this happens only with languages which have different variations, like en_US and en_GB, pt_PT and pt_BR. As I can see documentation website also has same codes in the URLs, look for example at Portuguese docs for Brasil and Portugal. Do you think we should drop them or maybe just handle case of en_US locale?

i could have sworn that i got a wrong link with fr_FR but i might have dreamed it: only en_US locale seems to be not return the right language, afaics.

@Harrissou: some background: at a certain point in time be decided to NOT use language_country ISO codes (like nl_BE, fr_FR) to minimize the amount of translations. We ONLY use the language code: fr, de, nl, en etc.
BUT some countries (Brazil, Portugal) considered their pt-language so different from each other that they really wanted 2 different translations. That is the reason why only there is pt_PT en pt_BR (en if I'm correct a khmer one which had another problem).

Also we tried to synchronize these 'language-codes' between QGIS-application, QGIS documentation, Transifex etc.

If I'm correct, the logic from Alexander just used those language codes (so is NOT looking into the locale of the Operating System).

Testing here: if I start (translated) QGIS 2.18 with:

qgis --lang nl

it successfully starts QGIS in dutch, but if I then click Help/Inhoudsopgave (F1) I go to
https://docs.qgis.org/2.18/en/docs/user_manual/
mmm, this should be
https://docs.qgis.org/2.18/nl/docs/user_manual/
...

Mmm, will look into this and report back which url exactly is fired, and if we redirect or not...

If there is something in the website we should fix, please let me know (as we are going to move the sites to another server in near future)...

For 2.18, at least 'en' seems hardcoded:

https://github.com/qgis/QGIS/blob/release-2_18/src/app/qgisapp.cpp#L9184

as in translation I do not think 'en' will be translated to 'fr' or 'uk' :-)

This could be fixed, though this is I think only used for the F1/help icon isn't it?

But..., you were talking about master....
What I see there is: IF QGIS is run with locale 'nl' then QGIS points rightfully to http://docs.qgis.org/testing/nl/docs/user_manual/index.html
which ... should be redirected to the english version, as there are no translations yet.

So THAT is a web server (my) problem...

Ok, I think that I have done the right redirectMatches now at docs.qgis.org to redirect a given language url to the right english one for testing.

EG, the help button in the open vector dialog is pointing to:
http://docs.qgis.org/2.99/nl/docs/user_manual/managing_data_source/opening_data.html#loading-a-layer-from-a-file
which will be redirected to:
docs.qgis.org/testing/en/docs/user_manual/managing_data_source/opening_data.html#loading-a-layer-from-a-file

If not, or you see other problems, please let me know

Can this issue be closed then?

For 2.18, at least 'en' seems hardcoded:
https://github.com/qgis/QGIS/blob/release-2_18/src/app/qgisapp.cpp#L9184
as in translation I do not think 'en' will be translated to 'fr' or 'uk' :-)

Actually, I do translate this kind of links, even though Transifex complains. As long as it's a valid link, I find it normal to translate instead of sending the user to an english page he'll then have to switch to french.
BUT... this is not the issue here.

EG, the help button in the open vector dialog is pointing to:
http://docs.qgis.org/2.99/nl/docs/user_manual/managing_data_source/opening_data.html#loading-a-layer-from-a-file
which will be redirected to:
docs.qgis.org/testing/en/docs/user_manual/managing_data_source/opening_data.html#loading-a-layer-from-a-file

Yes, this part of the issue I was raising is fixed (combined to the en_US bug Alex fixed days ago). Thanks to you!
What is remaining is the link for languages that are NOT provided in QGIS-Documentation. Try to open an icelandic help from QGIS. It'll still tries /testing/is/ and fails instead of switching to /testing/en/.

So THAT is a web server (my) problem...

Does it mean that any issue regarding the web side should be reported to you ? Only you are in charge of this? In which case, sorry for having moved the discussion here.

@Harrissou: well yes, most server stuff is my problem... Though I do not have a solution yet for the url's which are actually 404 (like pointing to a non available translation).

Also note that all this here, should only have an effect in master (only in master we go to either a zip or the online help via this class:

https://github.com/qgis/QGIS/blob/master/src/gui/qgshelp.cpp

I just created a Pull Request

https://github.com/qgis/QGIS/pull/5844

which made that a valid(!) help url like:

https://docs.qgis.org/2.99/en/docs/user_manual/working_with_ogc/ogc_client_support.html

to be not shown. Reason was that the check of a valid url did not handle the 301 redirection we (apparently) use.

What is the status of this report? Are all raised issues considered as fixed now?
Thanks.

Harrissou Santanna wrote:

What is the status of this report? Are all raised issues considered as fixed now?
Thanks.

Agree, can the involved people close or tag this open, as necessary? thanks!