Bug report #1672

keyColumn and sql are in wrong order in qgsdatasourceuri.cpp

Added by Horst Düster over 10 years ago. Updated over 10 years ago.

Status:Closed
Priority:Low
Assignee:Jürgen Fischer
Category:Data Provider
Affected QGIS version: Regression?:No
Operating System:All Easy fix?:No
Pull Request or Patch supplied: Resolution:fixed
Crashes QGIS or corrupts data: Copied to github as #:11732

Description

The new option keyColumn should appear after the option sql in src/core/qgsdatasourceuri.cpp.

With the trunk version former defined datasources allocates sql queries as keycolumn. After changing the order of &keyColumn and &sql everything works fine. Take a look at the code snippets please.

The definition also does't correspond with qgsdatasourceuri.h.

Wrong allocation:

void [[QgsDataSourceURI]]::setDataSource( const QString &schema,
                                      const QString &table,
                                      const QString &geometryColumn,
                                      const QString &keyColumn,
                                      const QString &sql )
{
  mSchema = schema;
  mTable = table;
  mGeometryColumn = geometryColumn;
  mKeyColumn = keyColumn;
  mSql = sql;
}

working allocation:

void [[QgsDataSourceURI]]::setDataSource( const QString &schema,
                                      const QString &table,
                                      const QString &geometryColumn,
                                      const QString &sql,
                                      const QString &keyColumn )
{
  mSchema = schema;
  mTable = table;
  mGeometryColumn = geometryColumn;
  mKeyColumn = keyColumn;
  mSql = sql;
}

Associated revisions

Revision 9172f472
Added by Jürgen Fischer over 10 years ago

fix #1672

git-svn-id: http://svn.osgeo.org/qgis/trunk/[email protected] c8812cc2-4d05-0410-92ff-de0c093fc19c

Revision 50c9b449
Added by Jürgen Fischer over 10 years ago

fix #1672

git-svn-id: http://svn.osgeo.org/qgis/[email protected] c8812cc2-4d05-0410-92ff-de0c093fc19c

History

#1 Updated by Jürgen Fischer over 10 years ago

  • Resolution set to fixed
  • Status changed from Open to Closed

fixed in 50c9b449 (SVN r10693)

Also available in: Atom PDF