Bug report #15373

Refine current rule not working on QGIS 2.16

Added by Alain FERRATON over 3 years ago. Updated over 2 years ago.

Status:Closed
Priority:Severe/Regression
Assignee:-
Category:Unknown
Affected QGIS version:2.16.0 Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:23303

Description

in an analysis rule-based.
Refine selected rules does nothing when valid with OK

Associated revisions

Revision ddbd25d0
Added by Nyall Dawson over 3 years ago

Correctly emit panelAccepted when panel is not in dock mode

Fixes #15373 - refine current rule not working when symbol widgets
are not used in the style dock

This fixes a behavioural difference when new panels are opened
in a QgsPanelWidget when in docked/undocked mode. When in
docked mode, the newly opened panel will emit panelAccepted
when it is accepted. But for undocked mode, the parent
panel was emitting the panelAccepted signal and so the
connection to update the renderer was never
triggered. Now both docked/undocked panels will always
emit panelAccepted ONLY from the newly opened panel itself.

This also fixes memory leaks as the clean up code was never
run in undocked mode.

I've updated the docs to clarify this behaviour.

Revision d073ca29
Added by Nyall Dawson over 3 years ago

Correctly emit panelAccepted when panel is not in dock mode

Fixes #15373 - refine current rule not working when symbol widgets
are not used in the style dock

This fixes a behavioural difference when new panels are opened
in a QgsPanelWidget when in docked/undocked mode. When in
docked mode, the newly opened panel will emit panelAccepted
when it is accepted. But for undocked mode, the parent
panel was emitting the panelAccepted signal and so the
connection to update the renderer was never
triggered. Now both docked/undocked panels will always
emit panelAccepted ONLY from the newly opened panel itself.

This also fixes memory leaks as the clean up code was never
run in undocked mode.

I've updated the docs to clarify this behaviour.

(cherry-picked from ddbd25d046ad514719b41c5f61f3c7fe34304a74)

Revision 93b1170c
Added by Nyall Dawson over 3 years ago

Correctly emit panelAccepted when panel is not in dock mode

Fixes #15373 - refine current rule not working when symbol widgets
are not used in the style dock

This fixes a behavioural difference when new panels are opened
in a QgsPanelWidget when in docked/undocked mode. When in
docked mode, the newly opened panel will emit panelAccepted
when it is accepted. But for undocked mode, the parent
panel was emitting the panelAccepted signal and so the
connection to update the renderer was never
triggered. Now both docked/undocked panels will always
emit panelAccepted ONLY from the newly opened panel itself.

This also fixes memory leaks as the clean up code was never
run in undocked mode.

I've updated the docs to clarify this behaviour.

(cherry-picked from ddbd25d046ad514719b41c5f61f3c7fe34304a74)

History

#1 Updated by Alain FERRATON over 3 years ago

This bug still exists in QGIS 2.16.3

#3 Updated by Nyall Dawson over 3 years ago

  • Status changed from Open to Closed

#4 Updated by Jürgen Fischer over 2 years ago

  • Category set to Unknown

Also available in: Atom PDF