Bug report #14414

Authenticated support in plugin installer fails when only download is authenticated

Added by Larry Shaffer over 4 years ago. Updated almost 3 years ago.

Status:Closed
Priority:Normal
Assignee:Larry Shaffer
Category:Authentication system
Affected QGIS version:2.14.0 Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:fixed/implemented
Crashes QGIS or corrupts data:No Copied to github as #:22395

Description

I added authentication system support to the plugin manager/installer in 36e7026.

That works if the entire plugin repo endpoint is authenticated, but fails if just the download of the plugin requires authentication. In the latter case, plugins are listed in the plugin manager via non-authenticated calls to http[s]://my.pluginrepo.tld/plugins.xml, however the actual download of the plugin's ZIP archive is from an HTTP[S] BASIC authentication directory, e.g. http[s]://my.pluginrepo.tld/packages/plugin.zip.

Note the connection does still work, i.e. prompting for the HTTP Basic auth credentials, though fails to use any predefined authentication system configuration.

The attached patch fixes this.

plugininstaller_patch.diff Magnifier (4.32 KB) Larry Shaffer, 2016-03-03 12:11 PM

History

#1 Updated by Larry Shaffer over 4 years ago

  • Resolution set to fixed/implemented
  • Status changed from In Progress to Closed

Fixed in b63461c

#2 Updated by Jürgen Fischer almost 3 years ago

  • Description updated (diff)

Also available in: Atom PDF