Feature request #14053

Symbol selector dialog: use same terms in the different properties of symbol layer

Added by Harrissou Santanna almost 9 years ago. Updated over 8 years ago.

Status:Closed
Priority:Normal
Assignee:-
Category:Symbology
Pull Request or Patch supplied:Yes Resolution:fixed/implemented
Easy fix?:No Copied to github as #:22064

Description

While designing a symbol (marker, line or fill), according to the symbol layer type chosen, in its properties:
  • "Rotation" is used in some cases while it's "Angle" in others
  • same thing for "Border" vs "Outline"
    It could be nice to use unique terms for all the dialogs

History

#1 Updated by Nyall Dawson almost 9 years ago

  • Status changed from Open to Feedback

Which version does this apply to? Can you give specifics?

#2 Updated by Harrissou Santanna almost 9 years ago

Hi Nyall,
I'm on 2.12.0 Trusty Tahr but didn't find anything different when (quickly) check these dialogs in master.
In the symbol selector dialog:
For a Marker Symbol: You have "Rotation" when the symbol layer type is Ellipse marker, Font marker while "Angle" is used for SVG Marker and simple marker
For a Fill Symbol : You have "Rotation" when the symbol layer type is Raster Image Fill, SVG Fill while "Angle" is used for Line Pattern Fill, Gradient Fill

Border is afaics consistently used for Fill symbol. So is Outline for Markers. However I wonder if we're not somehow talking about the same thing. Let's take for example the SVG Fill : the border is what is called outline for SVG Marker but it's just same thing.

#3 Updated by Jürgen Fischer almost 9 years ago

  • Subject changed from Symbol selector dialog: use identique terms in the different properties of symbol layer to Symbol selector dialog: use same terms in the different properties of symbol layer

#4 Updated by Harrissou Santanna almost 9 years ago

So, is this a valid issue? Which terms should be kept:
Rotation vs Angle ?
Border vs Outline ?
According to what's decided, i can propose a PR if no one has time.

#5 Updated by Harrissou Santanna over 8 years ago

  • Pull Request or Patch supplied changed from No to Yes

#6 Updated by Harrissou Santanna over 8 years ago

  • Resolution set to fixed/implemented
  • Status changed from Feedback to Closed

Also available in: Atom PDF