Bug report #12671
Cursor icon is too small on HiDPI screen
Status: | Closed | ||
---|---|---|---|
Priority: | Normal | ||
Assignee: | Alessandro Pasotti | ||
Category: | GUI | ||
Affected QGIS version: | master | Regression?: | No |
Operating System: | Easy fix?: | No | |
Pull Request or Patch supplied: | No | Resolution: | fixed/implemented |
Crashes QGIS or corrupts data: | No | Copied to github as #: | 20778 |
Description
Cursor icon size is hardcoded to 16x16 in many parts of the code (for example: https://github.com/qgis/QGIS/blob/master/src/app/qgisapp.cpp#L2317)
this makes the cursor very difficult to see.
The modification I suggest is to add a new QgsApp method that returns the zoom factor, calculated on a 96 dpi base, this will allow to resize all GUI parts by multiplying by the zoom factor.
To get current DPI you can use (Python code):
QgsApplication.instance().desktop().physicalDpiX()
The very same method could be used to resize icons and other GUI elements.
Related issues
Associated revisions
[bugfix][hidpi] Scalable SVG theme cursors
Add support for SVG cursor:
ZoomIn,
ZoomOut,
Identify,
CrossHair,
CapturePoint,
Select,
Sampler,
Icons are provisional: they need some love from
a decent graphics designer.
Fixes #12671
History
#1 Updated by Anita Graser about 9 years ago
- Assignee set to Alessandro Pasotti
#2 Updated by Giovanni Manghi over 7 years ago
- Priority changed from High to Normal
#3 Updated by Anita Graser over 7 years ago
- Affected QGIS version changed from 2.8.1 to master
- Target version set to Future Release - High Priority
This is still an issue.
For example, the identify tool cursor is so tiny that it is barely usable.
#4 Updated by Giovanni Manghi over 7 years ago
- Regression? set to No
- Easy fix? set to No
#5 Updated by Alessandro Pasotti almost 7 years ago
- Description updated (diff)
I have a working prototype and I can fix the C++ side for cursor icons that are
- scalable
- SVG-based
- themable
but I'm not that good at SVG for creating the icons themselves any volunteer?
we need the icons that are listed in this file:
https://github.com/qgis/QGIS/blob/master/src/gui/qgscursors.cpp#L23
#6 Updated by Anonymous almost 7 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
Applied in changeset qgis|7ae8e16427e5757d209f6cb18d1b247de8ef6be1.
#7 Updated by Giovanni Manghi almost 7 years ago
- Resolution set to fixed/implemented