Bug report #1234

Suspicious retrival of active layer in dxf2shp converter

Added by Mateusz Loskot - about 13 years ago. Updated about 13 years ago.

Status:Closed
Priority:Low
Assignee:nobody -
Category:C++ Plugins
Affected QGIS version: Regression?:No
Operating System:OS X Easy fix?:No
Pull Request or Patch supplied: Resolution:fixed
Crashes QGIS or corrupts data: Copied to github as #:11294

Description

In file [source:trunk/qgis/src/plugins/dxf2shp_converter/dxf2shpconverter.cpp?rev=9053#L114 dxf2shpconverter.cpp], lines 119-121, there are some actions implemented that seem to be garbage and never used:

[[QgsMapLayer]] *layer = mQGisIface->activeLayer();
if (layer)
    [[QgsVectorLayer]] *lyr = (QgsVectorLayer*)layer;

Or, it's a kind of logical error (cast and assignment to lyr object in local scope of if-condition) and the idea was to use the retrieved active layer but bits of usage are missing.

Associated revisions

Revision 4d9ba4f3
Added by Jürgen Fischer about 13 years ago

fix #1234 & #1235

git-svn-id: http://svn.osgeo.org/qgis/trunk/[email protected] c8812cc2-4d05-0410-92ff-de0c093fc19c

Revision 399e2636
Added by Jürgen Fischer about 13 years ago

fix #1234 & #1235

git-svn-id: http://svn.osgeo.org/qgis/[email protected] c8812cc2-4d05-0410-92ff-de0c093fc19c

History

#1 Updated by Mateusz Loskot - about 13 years ago

Sorry, the link to file is broken, here is corrected version: [source:trunk/qgis/src/plugins/dxf2shp_converter/[email protected]#L114 dxf2shpconverter.cpp]

#2 Updated by Jürgen Fischer about 13 years ago

  • Resolution set to fixed
  • Status changed from Open to Closed

thanks. fixed in

Also available in: Atom PDF