Bug report #11524
Relations Subforms - Start/Stop editing problem
|Affected QGIS version:||master||Regression?:||No|
|Operating System:||Easy fix?:||No|
|Pull Request or Patch supplied:||No||Resolution:|
|Crashes QGIS or corrupts data:||No||Copied to github as #:||19794|
There is a problem in toggle editing button of subforms.
To start editing, you need to click 2-3 times to toggle editing button. The same happens to stop editing.
This problem is recent in master, but I can not say how long, because I have not used this feature in master in the last days (maybe two weeks).
Tested with QGIS 2.5.0-115 (OSGeo4W 64bits).
invert back toggle editing button in relation editor widget (fixes #11524,
#8 Updated by Pedro Venâncio over 5 years ago
Giovanni Manghi wrote:
Denis Rouzaud wrote:
that did not solve the problem for me.
toggling the editing button does not change anything in the embed form.
seems to work here, just tested qgis 2.6 from osgeo4w.
I've tested it with QGIS 2.6 on Windows and Linux and the problem seems resolved.
#10 Updated by Larry Shaffer over 5 years ago
- Target version changed from Version 2.6 to Version 2.8
- Status changed from Closed to Reopened
- Priority changed from Severe/Regression to High
- Resolution deleted (
Not entirely fixed yet. If the child layer of the relation is left in edit mode when the dialog is closed, the 3-click issue (just for starting editing of the child) appears again on next opening of the same dialog.
Reopening the issue so another user may submit a suggested patch and sample project.
#11 Updated by Benjamin Trigona-Harany over 5 years ago
I did some testing and the issue appears to be that when creating QgsRelationEditorWidget, we need to set the button toggle state only once the relation feature is set with setRelationFeature(). You can see the bug in the attached project in 2.6.1 by editing the parent feature.
The attached patch should fix the issue.
#12 Updated by Matthias Kuhn over 5 years ago
- Status changed from Reopened to Closed
Patch applied in ba495f371
Thank you very much Benjamin.
If you have further fixes or improvements, it would be best to create pull requests for it on github, that way they can be easier reviewed, discussed and merged.