Bug report #11524

Relations Subforms - Start/Stop editing problem

Added by Pedro Venâncio almost 5 years ago. Updated over 4 years ago.

Status:Closed
Priority:High
Assignee:Matthias Kuhn
Category:Forms
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:19794

Description

There is a problem in toggle editing button of subforms.

To start editing, you need to click 2-3 times to toggle editing button. The same happens to stop editing.

This problem is recent in master, but I can not say how long, because I have not used this feature in master in the last days (maybe two weeks).

Tested with QGIS 2.5.0-115 (OSGeo4W 64bits).

bug.tar.bz2 - QGIS Project and data files (3.59 KB) Benjamin Trigona-Harany, 2015-01-11 12:52 PM

qgis_11524.diff Magnifier - patch (989 Bytes) Benjamin Trigona-Harany, 2015-01-11 12:52 PM

Associated revisions

Revision 48af5431
Added by Jürgen Fischer almost 5 years ago

invert back toggle editing button in relation editor widget (fixes #11524,
followup b1a2bef1)

Revision ba495f37
Added by Matthias Kuhn over 4 years ago

Correctly synchronize layer editable state with UI in relation editor

Fix #11524

Thank you very much Benjamin Trigona-Harany

History

#1 Updated by Pedro Venâncio almost 5 years ago

Sorry, I forgot to fill the Category -> Forms.

#2 Updated by Giovanni Manghi almost 5 years ago

  • Category set to Forms

I have seen this on master/linux too.

#3 Updated by Denis Rouzaud almost 5 years ago

  • Assignee set to Matthias Kuhn

I also confirm.
Would be quite painful to release with this one.

#4 Updated by Jürgen Fischer almost 5 years ago

quick sample project?

#5 Updated by Jürgen Fischer almost 5 years ago

  • Status changed from Open to Closed

#6 Updated by Denis Rouzaud almost 5 years ago

  • Status changed from Closed to Reopened

that did not solve the problem for me.
toggling the editing button does not change anything in the embed form.

#7 Updated by Giovanni Manghi almost 5 years ago

  • Status changed from Reopened to Feedback

Denis Rouzaud wrote:

that did not solve the problem for me.
toggling the editing button does not change anything in the embed form.

seems to work here, just tested qgis 2.6 from osgeo4w.

#8 Updated by Pedro Venâncio almost 5 years ago

Giovanni Manghi wrote:

Denis Rouzaud wrote:

that did not solve the problem for me.
toggling the editing button does not change anything in the embed form.

seems to work here, just tested qgis 2.6 from osgeo4w.

Hi Denis,

I've tested it with QGIS 2.6 on Windows and Linux and the problem seems resolved.

#9 Updated by Giovanni Manghi almost 5 years ago

  • Status changed from Feedback to Closed
  • Resolution set to fixed/implemented

I assume that this is really fixed as any test (on Windows and Linux) show it is, please reopen if necessary.

#10 Updated by Larry Shaffer over 4 years ago

  • Target version changed from Version 2.6 to Version 2.8
  • Status changed from Closed to Reopened
  • Priority changed from Severe/Regression to High
  • Resolution deleted (fixed/implemented)

Hi,

Not entirely fixed yet. If the child layer of the relation is left in edit mode when the dialog is closed, the 3-click issue (just for starting editing of the child) appears again on next opening of the same dialog.

Reopening the issue so another user may submit a suggested patch and sample project.

#11 Updated by Benjamin Trigona-Harany over 4 years ago

Hello,

I did some testing and the issue appears to be that when creating QgsRelationEditorWidget, we need to set the button toggle state only once the relation feature is set with setRelationFeature(). You can see the bug in the attached project in 2.6.1 by editing the parent feature.

The attached patch should fix the issue.

#12 Updated by Matthias Kuhn over 4 years ago

  • Status changed from Reopened to Closed

Patch applied in ba495f371
Thank you very much Benjamin.
If you have further fixes or improvements, it would be best to create pull requests for it on github, that way they can be easier reviewed, discussed and merged.

Also available in: Atom PDF