Bug report #8730

"Only look in the layer registry", but table scan still performed

Added by Sandro Santilli almost 6 years ago. Updated over 5 years ago.

Status:Closed
Priority:Normal
Assignee:Sandro Santilli
Category:Data Provider/PostGIS
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:fixed/implemented
Crashes QGIS or corrupts data:No Copied to github as #:17446

Description

I have "Only look in the layer registry" option activated, but when rendering the dialog to pick a layer to open I see queries sent to the backend for data in the actual tables (or views). I would expect queries to only look in layer registries instead (geometry_columns, geography_column etc).

Maybe it's my expectance being wrong, in which case there is probably a miswording of that option (it says "_only_ look...").

Associated revisions

Revision 7b45b40f
Added by Sandro Santilli over 5 years ago

Reword "Only look in the layer registries" option

The wording was confusing in that real table scans can still be
performed when the srid or type in the registries are found to
be unconstrained. The real effect of the option is to hide
layers which are not in the registries.

Fix #8730

History

#1 Updated by Sandro Santilli over 5 years ago

  • Affected QGIS version changed from 2.0.1 to master

I confirm this still happens in current master. It's with views having SRID=0 advertised in geometry_columns.
Running the full view scan (very slow) finds a real srid of 4326. Using estimated data relief the problem a little bit.

So, to recap: "Only look in layers registry" still looks in the actual datasource. Sounds like a bug to me.

#2 Updated by Sandro Santilli over 5 years ago

  • Pull Request or Patch supplied changed from No to Yes

Looking at the code and the tooltip I concluded it was a miswording of the option.
This pull request corrects it:

https://github.com/qgis/QGIS/pull/1148

#3 Updated by Sandro Santilli over 5 years ago

  • Status changed from Open to Closed

#4 Updated by Sandro Santilli over 5 years ago

  • Resolution set to fixed/implemented
  • Target version set to Version 2.2
  • Assignee set to Sandro Santilli

Also available in: Atom PDF