QGIS » QGIS Application

Sweet,

I have confirmed this works.

However, this logic:

2527        valid = true; 
     2528        if(fType == "GEOMETRY") 
     2529        { 
     2530            // check to see if there is a unique geometry type 
     2531            sql = QString("select distinct " 
     2532                            "case" 
     2533                            " when geometrytype(%1) IN ('POINT','MULTIPOINT') THEN 'POINT'" 
     2534                            " when geometrytype(%1) IN ('LINESTRING','MULTILINESTRING') THEN 'LINESTRING'" 
     2535                            " when geometrytype(%1) IN ('POLYGON','MULTIPOLYGON') THEN 'POLYGON'" 
     2536                            " end " 
     2537                          "from %2").arg(geometryColumn).arg(mSchemaTableName); 
     2538            if(mUri.sql!="") 
     2539                    sql += " where " + mUri.sql; 
     2540                            
     2541            result = executeDbCommand(connection, sql); 
     2542     
     2543            if (PQntuples(result)==1) 
     2544            { 
     2545                    fType = PQgetvalue(result, 0, 0); 
     2546            } 
     2547            PQclear(result); 

does not seem to be having the effect I assume it is intended to. That is, even though my layers have only polygon and multipolygon geometries, I am still given a selector with all three geometry groups (and defaulting to point).

I note that the recent fix to this ticket has introduced a couple of extra columns to the 'Add PostGIS Tables' dialog box and has also altered the way in which in the user now selects layers to be added.

I think that the new tickbox column is unnecessary - highlighting the names of the layers to be loaded worked well (for me at least) without the added complication of a tickbox. The tickboxes have also removed some of the multiple selection options that were available (e.g., to select all tables now requires the user to individually select all of the layers, compared to shift-clicking the top and bottom table names).

The 'Import As' column is redundant for columns that aren't of type 'geometry', and I suspect would confuse most users in that situation. Also, as mentioned above, when the layer is of geometry type, the selection given in the 'import as' column isn't restricted to the actual geometry types in the table. This would probably be expensive to find out for all spatial tables in a large database. Perhaps the selection of 'import as' geometry should be deferred to when the layer is loaded and where the code only needs to find out the geometry type for just the selected layers?

Gavin

Replying to [comment:2 warmerdam]:

However, this logic:
[...]
does not seem to be having the effect I assume it is intended to.

The dialog currently doesn't care about what the GEOMETRY columns actually carries. The user is expected to select what feature type he want's to see from the layer and the dialog then add a filter via where clause to just select these features.

The logic you're refering to is in the postgresprovider and actually triggered when the layer is added. It verifies that there is only one feature type in the (filtered) table. As the postgresprovider is not only use from the dialog.

Replying to [comment:3 g_j_m]:

I think that the new tickbox column is unnecessary - highlighting the names
of the layers to be loaded worked well (for me at least) without the added
complication of a tickbox. The tickboxes have also removed some of the
multiple selection options that were available (e.g., to select all tables
now requires the user to individually select all of the layers, compared to
shift-clicking the top and bottom table names).

The 'Import As' column is redundant for columns that aren't of type
'geometry', and I suspect would confuse most users in that situation. Also,
as mentioned above, when the layer is of geometry type, the selection given
in the 'import as' column isn't restricted to the actual geometry types in
the table. This would probably be expensive to find out for all spatial
tables in a large database. Perhaps the selection of 'import as' geometry
should be deferred to when the layer is loaded and where the code only needs
to find out the geometry type for just the selected layers?

You are certainly right about the loss of usablity. There's already a thread
that determines the feature types of views, which might also be expensive.

This could be extended to the GEOMETRY columns. In case GEOMETRY column only
contains a unique feature type everything could stay as it was. In case the
GEOMETRY column contain multiple feature type a combobox that actually contains
the available feature type could be used instead of the icon. Thereby avoiding
the need for an extra column.

I added the checkbox because the combobox don't look to well in selected lines.
By moving the combobox to the first column that reason might vanish to.

Thanks for the input. I'll try that.

Milestone Version 0.9.1 deleted