Bug report #7408

Atlas - some warnings are missing

Added by Regis Haubourg over 6 years ago. Updated over 6 years ago.

Status:Closed
Priority:Normal
Assignee:Hugo Mercier
Category:-
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:16375

Description

Hi,
some minor improvements for usability here:
- if expression in filename is not valid (say you changed coverage layer but not file name expression ) there is no warning, and atlas computes but nothing is output. We could add a check. resetting expressions when layer coverage choice is modified might not be a good idea. a warning + choice keep / reset could be nice

- when erasing filtering expression, OK button gets greyed out. A 'clear' button + OK valid should be enough. I did hav a error message with a expression filled with a unremoved space. That should not be evaluated as an expression (add a trim somewhere?)

régis

Associated revisions

Revision aa43c923
Added by Hugo Mercier over 6 years ago

refs #7408
Fix error reporting when the filename expression is invalid

Revision a482c42a
Added by Hugo Mercier over 6 years ago

refs #7408
[Atlas] Add a checkbox on "filter with"

Revision 53c47dd8
Added by Jürgen Fischer over 6 years ago

Merge pull request #473 from Oslandia/atlas

Atlas: fix #7408

History

#1 Updated by Hugo Mercier over 6 years ago

Ok for the addition of a check on expression validity.

Regarding your second point, what about a checkbox on "Filter with" ? I find it more consistent with the "Sort by" checkbox.

#2 Updated by Regis Haubourg over 6 years ago

Agreed with the checkbox, its more consistent.
régis

#3 Updated by Hugo Mercier over 6 years ago

  • Assignee changed from Vincent Picavet to Hugo Mercier

#4 Updated by Jürgen Fischer over 6 years ago

  • Status changed from Open to Closed

Also available in: Atom PDF