Bug report #4427

Disable options for interpretation of above/below and distancing when online labelling is selected

Added by Sandro Santilli about 9 years ago. Updated almost 9 years ago.

Status:Closed
Priority:Normal
Assignee:-
Category:Symbology
Affected QGIS version: Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:fixed
Crashes QGIS or corrupts data: Copied to github as #:14359

Description

The following changes since a2a6e78675833a4db0286a85354bf168032d2b49:
Juergen E. Fischer (1):
more cosmetics

are available in the git repository at:

:strk/Quantum-GIS.git labelui

Sandro Santilli (1):
Disable options related to interpretation and treatment of above/below line labeling when online labeling is requested.

src/app/qgslabelinggui.cpp   |    5 +++
src/ui/qgslabelingguibase.ui | 10 ++++++++
2 files changed, 15 insertions(+), 0 deletions(-)

History

#1 Updated by Martin Dobias almost 9 years ago

Applied in 627d25c6

btw. the easiest way how to provide patches (when you host your fork on github) is to do a pull request.

#2 Updated by Martin Dobias almost 9 years ago

  • Resolution set to fixed
  • Status changed from Open to Closed

#3 Updated by Sandro Santilli almost 9 years ago

Martin Dobias wrote:

Applied in 627d25c6

btw. the easiest way how to provide patches (when you host your fork on github) is to do a pull request.

Thanks.
Note that I'm intentionally avoiding the "github way" as I belive it's a bad habit to rely on proprietary tools (and graphical interfaces too, but that's a minor thing).

Once you add a remote pointing to my fork pulling the change is a easy as
"git pull strk labelui"
or whatever I advertise as the branch containing the contribution.

#4 Updated by Martin Dobias almost 9 years ago

Sandro Santilli wrote:

Note that I'm intentionally avoiding the "github way" as I belive it's a bad habit to rely on proprietary tools (and graphical interfaces too, but that's a minor thing).

Once you add a remote pointing to my fork pulling the change is a easy as
"git pull strk labelui"
or whatever I advertise as the branch containing the contribution.

Okay - didn't know it was intentional. Anyway in my opinion rather than "relying" on the proprietary tools (github) we may use them to increase the productivity... we can stop using it any time. For small patches the pull requests are really useful - one click to merge instead of having to add remotes, do pulls/pushes and review changes in terminal.

Also available in: Atom PDF