Bug report #3916

QgsUniqueValueRenderer::operator= must return a value

Added by Mateusz Loskot - over 14 years ago. Updated about 11 years ago.

Status:Closed
Priority:Low
Assignee:Gary Sherman
Category:Vectors
Affected QGIS version: Regression?:No
Operating System:All Easy fix?:No
Pull Request or Patch supplied: Resolution:fixed
Crashes QGIS or corrupts data: Copied to github as #:13940

Description

Assignment operator must return a value.
Trying to compile this code using VC++ or Comeau C/C++:

struct A
{
   A& operator=(A const& rhs)
   {
   }
};

I get this error:

MODE:strict errors C++

"ComeauTest.c", line 5: warning: missing return statement
at end of non-void function
"A::operator=" 
}
^

This is ISO C++ conformant behaviour.

There are many assignment operators defined as not
returning any value. This is a bug!

History

#1 Updated by Gary Sherman over 14 years ago

  • Status changed from Open to In Progress

As far as I can tell, it does return a value.

#2 Updated by Mateusz Loskot - over 14 years ago

Yes, as I see in the logs, timlinux applied those changes:

https://svn.qgis.org/trac/changeset/5060

#3 Updated by Gavin Macaulay - over 14 years ago

  • Resolution set to fixed
  • Status changed from In Progress to Closed

Resolved in d2b74ca7 (SVN r5061)

#4 Updated by Anonymous about 11 years ago

Milestone Version 0.8 deleted

Also available in: Atom PDF