Feature request #3434
new symbology line decoration with wrong orientation
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Low | ||
| Assignee: |  Martin Dobias | ||
| Category: | Symbology | ||
| Pull Request or Patch supplied: | Resolution: | fixed | |
| Easy fix?: | No | Copied to github as #: | 13494 |
Description
I'm showing 2 lines with new symbology and line decoration.
Both lines are horizontal 2 points segments.
The one above goes right-to-left.
The one below goes left-to-right.
I would expect the line decoration (kind of an arrow head) to go
in the direction of the line, but this is not happening for the right-to-left one.
Here's a snapshot:
http://strk.keybit.net/tmp/qgis_new_symbology_line_decoration.png
For reference, WKT of the two lines:
10: LINESTRING
13: LINESTRING
This is qgis r15056
0001-Fix-math-used-to-compute-angles-of-horizontal-and-ve.patch 
(1.05 KB)
3434.diff
- The attached patch is shorter, but I didn't test it - strk could you try it with your testcase, please?
(1.23 KB)
Associated revisions
fix #3434
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@15076 c8812cc2-4d05-0410-92ff-de0c093fc19c
fix #3434
git-svn-id: http://svn.osgeo.org/qgis/trunk@15076 c8812cc2-4d05-0410-92ff-de0c093fc19c
History
#1
Updated by Sandro Santilli over 13 years ago
Further debugging shows that the problem has to do with the final segment being exactly horizontal.
I suspect there's en equal problem with perfectly vertical lines, as per
this other snapshot:
http://strk.keybit.net/tmp/ArrowHeadHell.png
#2
Updated by Sandro Santilli over 13 years ago
Found and fixed. Attached format-patch (good to apply with git-am).
Problem was for both vertical and horizontal lines. Fixed the vertical case (int vs. float) and the horizontal case (just missing).
#3
Updated by Sandro Santilli about 13 years ago
jef suggested this much simplified version: http://paste.debian.net/105578/
I've tested it and works fine.
#4
Updated by Jürgen Fischer about 13 years ago
- Resolution set to fixed
- Status changed from Open to Closed
Replying to [comment:4 strk]:
jef suggested this much simplified version: http://paste.debian.net/105578/
I've tested it and works fine.
Thanks. Applied in 895c4a40 (SVN r15077).