Feature request #316
Added some tr (i18n support)
|Assignee:||Gavin Macaulay -|
|Pull Request or Patch supplied:||Resolution:||fixed|
|Easy fix?:||No||Copied to github as #:||10375|
Added some tr() for user visible text
#1 Updated by anonymous - over 14 years ago
Thanks for the patch. I've applied, tested and committed most of them in SVN f7117cb6 (SVN r5887) (but see below).
In qgsdelimitedtextprovider.cpp you replaced the line
QString filter = QString("Shapefiles (*.shp)");
QString filter = QString(tr("Shapefiles (*.shp)"));
I'm not familiar with how file suffixes change with languages, but is it correct to translate the *.shp too, given that this is used to select which files are visible in the dialog box?
I also changed the patch for the qgslabelattributes.cpp file as it was missing the tr() function.
#2 Updated by Redmine Admin over 14 years ago
"_I'm not familiar with how file suffixes change with languages, but is it correct to translate the *.shp too, given that this is used to select which files are visible in the dialog box? _"
Of course suffixes don't change with language but there is also some additional text which could be useful to translate. Maybe in future if only one open dialog box would be used for all layer types (grass, raster, vector) it could be this text more verbose (e.g. "Vector ESRI shapefile (*.shp)") so the string "Vector" should be translated. Probably it it only theoretical argument for now but in general the "File filters" used to be translatable in the most of KDE applications (Koffice, Kpdf,...).