Feature request #2999
msvc compilation
Status: | Closed | ||
---|---|---|---|
Priority: | Low | ||
Assignee: | Jürgen Fischer | ||
Category: | Build/Install | ||
Pull Request or Patch supplied: | Resolution: | fixed | |
Easy fix?: | No | Copied to github as #: | 13059 |
Description
Hello,
Some files in the project have unnecessary unistd.h include, which causes them not to compile under msvc.
Another issue on Windows, iconv package from GnuWin32 is named libiconv.lib, so FindIconv.cmake doesn't find it.
Both issues are handled in the attached patch (tested also on linux, it doesn't break anything)
History
#1 Updated by Jürgen Fischer about 14 years ago
- Resolution set to fixed
- Status changed from Open to Closed
applied in 0880c2c7 (SVN r14581).