Feature request #2273

patch to have a single window icon on Microsoft Windows

Added by Steven Mizuno almost 10 years ago. Updated almost 10 years ago.

Status:Closed
Priority:Low
Assignee:nobody -
Category:Build/Install
Pull Request or Patch supplied: Resolution:fixed
Easy fix?:No Copied to github as #:12333

Description

On Windows builds of QGIS I have noticed that there are two slightly different window icons in various windows. This is not the case for Linux builds.

I found that a main window icon is set in QgisApp. For Microsoft Windows there is an icon placed in a resource file, which becomes the application icon. The main window icon is displayed on the QGIS main window and for any window it owns. The application icon (from the resource) is used for all windows not owned by the main window.

It is better if an application icon is set on the QApplication object so all windows inherit this icon unless a different icon is set for a window.

This patch removes the window icon set in QgisApp. For Linux/Mac it sets the application icon in the constructor of QgsApplication. For Windows, the icon in the resource is the application icon (no icon is set in QgsApplication).

patch-QgisApp-QgsApplication-_application_icon_-20091210.txt Magnifier (1.43 KB) Steven Mizuno, 2009-12-12 10:38 AM

History

#1 Updated by Jürgen Fischer almost 10 years ago

  • Resolution set to fixed
  • Status changed from Open to Closed

applied in b4aaa2fd (SVN r12425). Thanks.

Also available in: Atom PDF