Bug report #21797

parameter type error in SAGA Gaussian Filter

Added by Garth Fletcher 4 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assignee:Victor Olaya
Category:Processing/SAGA
Affected QGIS version:3.6.1 Regression?:No
Operating System: Easy fix?:Yes
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:29612

Description

SAGA Gaussian Filter parameter window only accepts type Integer for "Standard Deviation" field, but should accept type Real.
Problem seems to be in 4th line of:
/Applications/QGIS_3_6_1-1.app/Contents/Resources/python/plugins/processing/algs/saga/description/GaussianFilter.txt:

incorrectly reads as:
QgsProcessingParameterNumber|SIGMA|Standard Deviation|QgsProcessingParameterNumber.Integer|1|False|None|None

which should instead be:
QgsProcessingParameterNumber|SIGMA|Standard Deviation|QgsProcessingParameterNumber.Double|1.00|False|None|None

Associated revisions

Revision 83e6dd3e
Added by Victor Olaya 3 months ago

[processing] fixed description of SAGA gaussian filter algorithm

Fixes #21797

History

#1 Updated by Garth Fletcher 4 months ago

Proof of concept: editing /Applications/QGIS_3_6_1-1.app/Contents/Resources/python/plugins/processing/algs/saga/description/GaussianFilter.txt to change line 4 to
QgsProcessingParameterNumber|SIGMA|Standard Deviation|QgsProcessingParameterNumber.Double|1.00|False|None|None
fixes the problem and allows real number input.
Of course any new installation will revert to the original Integer setting, so getting this fixed in the distribution would be appreciated.

#2 Updated by Giovanni Manghi 4 months ago

  • Operating System deleted (Mac OS X 10.12.6)
  • Assignee set to Giovanni Manghi
  • Status changed from Open to Feedback

Garth Fletcher wrote:

Proof of concept: editing /Applications/QGIS_3_6_1-1.app/Contents/Resources/python/plugins/processing/algs/saga/description/GaussianFilter.txt to change line 4 to
QgsProcessingParameterNumber|SIGMA|Standard Deviation|QgsProcessingParameterNumber.Double|1.00|False|None|None
fixes the problem and allows real number input.
Of course any new installation will revert to the original Integer setting, so getting this fixed in the distribution would be appreciated.

Can you do a Pull Request on GitHub with this fix?

#3 Updated by Garth Fletcher 4 months ago

Unfortunately doing a Pull Request" is way above my knowledge level. I would greatly appreciate some competent person installing my suggested fix.

#4 Updated by Victor Olaya 3 months ago

  • Assignee changed from Giovanni Manghi to Victor Olaya

#5 Updated by Victor Olaya 3 months ago

  • % Done changed from 0 to 100
  • Status changed from Feedback to Closed

Also available in: Atom PDF