Bug report #20246

packaging: icons/desktop/mimeinfo files should also be installed/processed on BSD

Added by landry Landry Breuil over 1 year ago. Updated over 1 year ago.

Status:Closed
Priority:Normal
Assignee:landry Landry Breuil
Category:Build/Install
Affected QGIS version:3.4.0 Regression?:No
Operating System:OpenBSD Easy fix?:Yes
Pull Request or Patch supplied:Yes Resolution:fixed/implemented
Crashes QGIS or corrupts data:No Copied to github as #:28067

Description

There's been nice improvements in linux packaging recently for 3.4 (ie https://github.com/qgis/QGIS/commit/52a80d895c45876bfdf97d194c7f666031412b5d, https://github.com/qgis/QGIS/commit/db398ab1b55d4d1be23ec73f723d413fc218730a, https://github.com/qgis/QGIS/commit/618c3ce368a93aa614b534af7b1f867c25d7aabe, etc..) and the BSDs shouldnt be left out of this ! :)

All those IF (CMAKE_SYSTEM_NAME STREQUAL "Linux") should be fixed - maybe UNIX unless that includes macosx ?

History

#1 Updated by landry Landry Breuil over 1 year ago

Maybe that should be (UNIX AND NOT APPLE) in cmake-speak..

#2 Updated by landry Landry Breuil over 1 year ago

  • Assignee set to landry Landry Breuil

#3 Updated by Giovanni Manghi over 1 year ago

  • Pull Request or Patch supplied changed from No to Yes
  • Category changed from Unknown to Build/Install

#4 Updated by Loïc BARTOLETTI over 1 year ago

  • Resolution set to fixed/implemented
  • Status changed from Open to Closed

Thanks Landry

Also available in: Atom PDF