Bug report #19824

Modifications to project models are not saved

Added by Olivier Dalang about 2 years ago. Updated about 2 years ago.

Status:Closed
Priority:Normal
Assignee:-
Category:Processing/Modeller
Affected QGIS version:3.3(master) Regression?:No
Operating System:Windows 10 Easy fix?:No
Pull Request or Patch supplied:Yes Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:27648

Description

Hi !

Modifications to project models are not saved.

Steps to reproduce :

1. Create a model
2. Save it to the project (using the dedicated button)
3. Close.
4. Open the model (right-click, edit model)
5. Make some changes
6. Save it to the project again (using the dedicated button)
7. Close
8. Reopen the model

The modifications were not saved.

Expected results :

The model should be overwritten, opt. with a confirmation dialog.

Workarounds :

Manually delete the previous model before saving or save under another name.

Thanks for that models in project feature which will be very useful !!

Associated revisions

Revision 340631f8
Added by Olivier Dalang about 2 years ago

fix #19824 where modifications to project models were not saved

Models definitions are now stored in a dict rather than list
which allows for less verbose code to reference models by name

History

#2 Updated by Giovanni Manghi about 2 years ago

  • Pull Request or Patch supplied changed from No to Yes

#3 Updated by Olivier Dalang about 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

Also available in: Atom PDF