Bug report #18152

QGIS 3.0 - Data Source Manager Dialog - default behavior has changed

Added by Mark Johnson almost 3 years ago. Updated over 2 years ago.

Status:Closed
Priority:Low
Assignee:-
Category:GUI
Affected QGIS version:master Regression?:No
Operating System:Linux, Ubuntu Easy fix?:Yes
Pull Request or Patch supplied:No Resolution:fixed/implemented
Crashes QGIS or corrupts data:No Copied to github as #:26045

Description

At some point in the last months the default behavior of the Data Source Manager Dialog has changed so that when open, no interaction with the main window is possible.

I assume this has to do with the missing 'min', 'full' window buttons (on my system right) together with the 'X' button to close the dialog.

When selecting Layers, it is useful to see/confirm that one is loading everything that is wanted.
This behavior also make the 'Keep dialog open' CheckBox, that many SourceSelect's offer, rather useless.

This was probably just overlooked during some overall. but is really counterproductive in its present state.

20180220.DataSourceManager.png (195 KB) Mark Johnson, 2018-02-21 05:02 AM

Associated revisions

Revision 1090312c
Added by Harrissou Santanna over 2 years ago

Add more information to modeless option

fix #18152

Revision 7487be0e
Added by Harrissou Santanna over 2 years ago

Add more information to modeless option

fix #18152

(cherry-picked from 1090312c64)

History

#1 Updated by Mark Johnson almost 3 years ago

This observation is based on the code as of 2018-02-10.

#2 Updated by Richard Duivenvoorde almost 3 years ago

Mark we are talking here about modal vs non modal dialogs isn't it?

In current master, the Data Source Manager Dialog is NOT modal, that is if it is opened and I just added a layer/datasource, I can still pan the map, or change visibility in the layer manager.

Is that different from what you describe? I'm on Debian here, latest master

#3 Updated by Mark Johnson almost 3 years ago

Based on a rebase from yesterday of master, this problem still occurs.
(QGIS version 2.99.0-Master QGIS code revision 789756d)
Ubuntu 14.10 using GNOME.

While the Data Source Manager Dialog (with only an X-Button, instead of the Min/Full/X-Buttons) is open, the main QGis cannot be activated. (see Image)

#4 Updated by Regis Haubourg almost 3 years ago

I confirm that on ubuntu 16.04 with 585a4d3 that the dialog is modal, not letting any use of the underlying QGIS main interface.
Not sure it is a high priority though

#5 Updated by Regis Haubourg almost 3 years ago

  • Status changed from Open to Feedback
  • Priority changed from High to Low

Oh,
by chance I discovered that it is now a setting in the option dialog/General tab. So Mark, can you confirm changing the option solves your issue?

#6 Updated by Mark Johnson almost 3 years ago

Yes, that seems to help, assuming you know the difference (which I always forget) between modal and non modal dialogs.

Class Qt.WindowModality
A modal window is one that blocks input to other windows. Note that windows that are children of a modal window are not blocked.

So a ToolTip with 'A modal window is one that blocks input to other windows.' would be useful.

It still only has an X-Button, instead of the Min/Full/X-Buttons, so you have to maneuver the window out of the way instead of pressing 'Min' which is the expected behavior.

#7 Updated by Harrissou Santanna over 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

#8 Updated by Giovanni Manghi over 2 years ago

  • Resolution set to fixed/implemented

Also available in: Atom PDF