Bug report #18145

Do not enable OK buttons if dialogs are missing required fields

Added by Johannes Kroeger about 6 years ago. Updated about 5 years ago.

Affected QGIS version:3.6.0 Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:
Crashes QGIS or corrupts data:No Copied to github as #:26038


I named this bug generally although I only have two specific examples.

#18144 mentions a dialog presenting OK and Cancel, both allowing to quit doing nothing.

The XYZ Connection dialog also let's the user proceed without entering a name. Without a name no connection will get saved so the entered detail is lost if the user clicks OK.

This is also possible with the MSSQL, PostGIS, DB2 dialogs.

It is not working (i.e. set up great) for example in the ArcGISFeature- and -MapServer as well as WCS, WMS, WFS.

Please only enable OK buttons if things are OK. Otherwise do not let the user click OK.

Not sure if this style of issue is good, close at will (or if the examples are fixed). ;)

should not be able to click ok just now.png (39.3 KB) Johannes Kroeger, 2018-02-19 01:35 PM


#1 Updated by Giovanni Manghi about 5 years ago

  • Status changed from Open to Feedback

Please check if this issue is still valid on QGIS 3.4.5 or 3.6.

#2 Updated by Johannes Kroeger about 5 years ago

  • Status changed from Feedback to Open

Replicated with PostGIS dialog in 3.6.0-Noosa. Did not try other dialogs.

#3 Updated by Giovanni Manghi about 5 years ago

  • Affected QGIS version changed from master to 3.6.0

Also available in: Atom PDF