Bug report #18115

New offset tool

Added by Loïc BARTOLETTI over 2 years ago. Updated over 2 years ago.

Status:Closed
Priority:Normal
Assignee:Denis Rouzaud
Category:Digitising
Affected QGIS version:master Regression?:No
Operating System: Easy fix?:No
Pull Request or Patch supplied:No Resolution:fixed/implemented
Crashes QGIS or corrupts data:No Copied to github as #:26009

Description

I have this bugs with the new offset tool (see the screenshots)

- Join style combobox is by default empty
- Moving the cursor can be counterintuitive (negative value to expand and positive value to decrease)
- Result can be strange

Also, this tool for polygon is enable only when you click on the border should be enabled wherever you click on the polygon

Screenshot-2018-02-15-09-52-47.png - Empty join style ; negative value for positive buffer (80.8 KB) Loïc BARTOLETTI, 2018-02-15 06:23 PM

Screenshot-2018-02-15-18-33-09.png - strange buffer (48.5 KB) Loïc BARTOLETTI, 2018-02-15 06:33 PM

test.gpkg (120 KB) Loïc BARTOLETTI, 2018-02-15 06:36 PM

Associated revisions

Revision 45bfa50c
Added by Denis Rouzaud over 2 years ago

[offset tool] fix #18115 improved offset calculation

  • use QgsGeometry::contains for polygons (contains => negative offset)
  • use the geometry part and not the whole geometry to find closest segment

History

#1 Updated by Denis Rouzaud over 2 years ago

I'm on it!
Thanks for reporting.

#2 Updated by Denis Rouzaud over 2 years ago

There is something strange with the polygon in your data. I can't edit the nodes of the small part and the geometry is invalid.

#3 Updated by Loïc BARTOLETTI over 2 years ago

Yes, see also #18116 (found testing your offset tool). The original geometry is a valid simple polygon

#4 Updated by Denis Rouzaud over 2 years ago

  • % Done changed from 0 to 100
  • Status changed from Open to Closed

#5 Updated by Giovanni Manghi over 2 years ago

  • Resolution set to fixed/implemented

Also available in: Atom PDF