Feature request #1805

Unique Value Renderer multiple class selection issue

Added by gcarrillo - about 10 years ago. Updated about 10 years ago.

Status:Closed
Priority:Low
Assignee:gcarrillo -
Category:Symbology
Pull Request or Patch supplied: Resolution:fixed
Easy fix?:No Copied to github as #:11865

Description

On Unique Value Renderer, when I select multiple classes on the class list and edit a double setting (lineWidth or pointSize) I get bad behavior of the enable/disable spinBoxes. Even when the selected classes has the same setting (lineWidth or pointSize) the spinBox is disabled.

patch_for_bug_1805.txt Magnifier - Patch for this minor issue. (1.94 KB) gcarrillo -, 2009-07-25 01:56 PM

Associated revisions

Revision ac197ecb
Added by Jürgen Fischer about 10 years ago

fix #1805

git-svn-id: http://svn.osgeo.org/qgis/trunk/[email protected] c8812cc2-4d05-0410-92ff-de0c093fc19c

Revision 4e881148
Added by Jürgen Fischer about 10 years ago

fix #1805

git-svn-id: http://svn.osgeo.org/qgis/[email protected] c8812cc2-4d05-0410-92ff-de0c093fc19c

History

#1 Updated by Giovanni Manghi about 10 years ago

Hi,

thanks for the patch.

Have you seen #1703? Is this related?

#2 Updated by gcarrillo - about 10 years ago

The #1703 ask for new color buttons behavior (and others) when multiple classes are selected.

The code for this class set to disabled each symbology setting when the classes has different value for this setting. As jef says, it is intentional. I think the #1703 enhancement could be useful.

So, this is related with #1703 but only fix a little thing and doesn't make nothing for that.

#3 Updated by Giovanni Manghi about 10 years ago

Hi,

I gave a better look/try to #1703 and it seems to me that it also fixes the small problem that lead you to create this patch. In fact if you leave the "restrict changes to common properties" check-box unchecked, you can change the lineWidth or pointSize of multiple classes selection regardless if the lineWidth or pointSize is the same or if it is different.

#4 Updated by Giovanni Manghi about 10 years ago

I gave another look, and at the end it seems I was wrong, in fact I noticed now that if I leave the "restrict changes to common properties" check-box unchecked, then obviously all the classes will take the same style options.

As a matter of fact if I select a few classes, change the outline width, unselect them and then select them again, the outline width selector is disabled, so your patch will correct indeed this issue.

I'll give it a try and I will report back.

#5 Updated by Giovanni Manghi about 10 years ago

Replying to [comment:4 lutra]:

I'll give it a try and I will report back.

the patch works for me under Ubuntu 9.04

#6 Updated by gcarrillo - about 10 years ago

Thanks lutra, just a thing: The patch contains the function isEqual, which can be useful to other classes in spite of be a very small function. I don't know if QGis has something like Utils class or something like that where it could be better placed.

#7 Updated by Jürgen Fischer about 10 years ago

Replying to [comment:6 gcarrillo]:

Thanks lutra, just a thing: The patch contains the function isEqual, which can be useful to other classes in spite of be a very small function. I don't know if QGis has something like Utils class or something like that where it could be better placed.

I introduced a function to compare doubles yesterday. makes use of that now.

#8 Updated by Giovanni Manghi about 10 years ago

  • Resolution set to fixed
  • Status changed from Open to Closed

I introduced a function to compare doubles yesterday. makes use of that now.

works for me

Also available in: Atom PDF