QGIS » QGIS Application

Could this be related to: #14756 ?

Here on a Windows computer with 2.14.1 (I know.. old...) it does not refresh the name when hovering over the panel (like it does on a Linux desktop). You have to click(!) in the legend panel (or on the legend panel title bar) to have it repainted.

There are some missing signals, that is why the updates do not work automatically. For 2.x one could use this as a workaround:

model = iface.layerTreeView().model()
index = model.node2index(treenode)
model.setData(index, 'new name')

The issue is there also when renaming raster layers (for unknown reasons only vector layers used to have name changed signal).

For master/3.0 I will make a fix, and possibly port it to 2.18.x

@Martin: Tested and Working in 3.0. thanks!

Looking at this line
https://github.com/qgis/QGIS/blob/master/src/core/layertree/qgslayertreemodel.cpp#L206
I think the creation of a layername+featurecount is also done there, but I'm not sure if this also fixes this issue:
#14756
which is working with "layer.setSubsetString(subsetString)"...
which also should update the 'name' of the layer because it contains the featurecount...

What do you think, is that also fixed now? I cannot test because TimeManager is not working yet in QGIS3...

Do you think we could/should cherrypick this to 2.16 or 2.18?

I will port the fix to 2.18. (2.14 would need extra patching, 2.16 is not updated)

#14756 is a different problem - setSubsetString() does not have a specific signal to be emitted to indicate that feature count needs to be updated.

@Martin I tested in 2.18: OK now

but instead of creating a 'setName' signal, shouldn't there be a more generic signal? To update the layertree labels?

I reckon more plugins/functions will start updating names/featurecounts/whateverfuturebrings and it would be good to have a 'updatelegend' signal or so? So it can be used as some "'repaint/reconstruct' the legend again based on the model"?

Or do you think that is overkill?

The layer tree does not know anything about legend, so requests for legend update need to be handled elsewhere. Layer tree only cares about groups and layers.

There is QgsLayerTreeModel::refreshLayerLegend(nodeLayer) method to update legend of a layer in a particular tree model. It is already called automatically on various occasions.